Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic "dvc add" workflow to DVC tracked panel #5037

Open
shcheklein opened this issue Nov 29, 2023 · 1 comment
Open

Add basic "dvc add" workflow to DVC tracked panel #5037

shcheklein opened this issue Nov 29, 2023 · 1 comment
Labels
A: data enhancement New feature or request priority-p2 Future feature, less priority for now

Comments

@shcheklein
Copy link
Member

For simpler onboarding (and tutorial) it would be handy to have a button like this.
It can cover only new files (no complicated scenarios like adding files into a directory and such).
+ Icon and a "wizard" is enough
It should cover a scenario when data is tracked by Git (it's needed to the onboarding tutorial). If this is too complicated we can postpone the whole feature since it won't move the needle at the moment most likely.

@shcheklein shcheklein added enhancement New feature or request priority-p1 Regular product backlog triage A: data labels Nov 29, 2023
@mattseddon
Copy link
Member

We already have the ability to add untracked files via the SCM panel:

Screen.Recording.2023-11-30.at.2.32.03.pm.mov

and we do have "Add Data" via the tracked tree:

Screen.Recording.2023-11-30.at.2.37.28.pm.mov

It does seem like a couple of days work to add this to the file explorer context menu as we will have to run some git commands up front in order to be able to run dvc add for files tracked by Git:

dvc add .github 
ERROR:  output '.github' is already tracked by SCM (e.g. Git).

    You can remove it from Git, then add to DVC.

        To stop tracking from Git:

            git rm -r --cached '.github'

            git commit -m "stop tracking .github" 

We also know how unstable things start getting when we chain commands together.

Other things to consider:

  1. show message if resource is already tracked by DVC.
  2. do not try to git rm files that are not tracked by Git.
  3. multi-project workspace with subprojects, need to work out which project to add to.

@shcheklein shcheklein added priority-p2 Future feature, less priority for now and removed priority-p1 Regular product backlog triage labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: data enhancement New feature or request priority-p2 Future feature, less priority for now
Projects
None yet
Development

No branches or pull requests

2 participants