Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path not supported for some path arguments #769

Open
AlexandreKempf opened this issue Feb 5, 2024 · 2 comments
Open

Path not supported for some path arguments #769

AlexandreKempf opened this issue Feb 5, 2024 · 2 comments
Labels
A: dvcyaml Area: `live.make_dvcyaml` bug Did we break something? p2-medium

Comments

@AlexandreKempf
Copy link
Contributor

Most of the path arguments handle both str and pathlib.Path object.

It is not the case for Live's dvcyaml while it should probably be.

@dberenbaum dberenbaum added bug Did we break something? A: dvcyaml Area: `live.make_dvcyaml` labels Feb 5, 2024
@AbdullahMakhdoom
Copy link

AbdullahMakhdoom commented Jun 1, 2024

Hi @dberenbaum, I'm interested in contributing to dvclive, and I believe this issue is a great starting point.
If I'm not mistaken, it appears that the Live's dvcyaml argument should also accept pathlib.Path objects. Therefore, the argument should be defined as dvcyaml: Optional[Union[str, pathlib.Path]] = "dvc.yaml"
Could you confirm if my understanding is correct?

@dberenbaum
Copy link
Contributor

If I'm not mistaken, it appears that the Live's dvcyaml argument should also accept pathlib.Path objects.

Correct.

Therefore, the argument should be defined as dvcyaml: Optional[Union[str, pathlib.Path]] = "dvc.yaml"

Partially correct. Fixing the type hint would be nice, but the underlying issue goes deeper. If you try an example with dvcyaml set to some pathlib.Path value, you should see where it breaks. This issue is to fix any underlying problems so that pathlib.Path values work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: dvcyaml Area: `live.make_dvcyaml` bug Did we break something? p2-medium
Projects
None yet
Development

No branches or pull requests

3 participants