You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @dberenbaum, I'm interested in contributing to dvclive, and I believe this issue is a great starting point.
If I'm not mistaken, it appears that the Live's dvcyaml argument should also accept pathlib.Path objects. Therefore, the argument should be defined as dvcyaml: Optional[Union[str, pathlib.Path]] = "dvc.yaml"
Could you confirm if my understanding is correct?
If I'm not mistaken, it appears that the Live's dvcyaml argument should also accept pathlib.Path objects.
Correct.
Therefore, the argument should be defined as dvcyaml: Optional[Union[str, pathlib.Path]] = "dvc.yaml"
Partially correct. Fixing the type hint would be nice, but the underlying issue goes deeper. If you try an example with dvcyaml set to some pathlib.Path value, you should see where it breaks. This issue is to fix any underlying problems so that pathlib.Path values work.
Most of the path arguments handle both
str
andpathlib.Path
object.It is not the case for
Live
'sdvcyaml
while it should probably be.The text was updated successfully, but these errors were encountered: