Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check integrations and update them to log params #317

Open
3 of 8 tasks
shcheklein opened this issue Oct 1, 2022 · 3 comments
Open
3 of 8 tasks

Check integrations and update them to log params #317

shcheklein opened this issue Oct 1, 2022 · 3 comments
Labels
A: frameworks Area: ML Framework integration enhancement p2-medium

Comments

@shcheklein
Copy link
Member

shcheklein commented Oct 1, 2022

E.g. in the Lighting logger there is call:

    @rank_zero_only
    def log_hyperparams(self, params, *args, **kwargs):
        pass

should we utilize it to automatically track things?

Edit: add checkboxes per framework in order of priority based on framework pageviews

@shcheklein shcheklein added enhancement A: frameworks Area: ML Framework integration labels Oct 1, 2022
@shcheklein shcheklein changed the title log_param: check integrations and update them log params Check integrations and update them to log params Oct 1, 2022
@daavoo
Copy link
Contributor

daavoo commented Oct 3, 2022

should we utilize it to automatically track things?

Yes, we should use log_params there

@daavoo
Copy link
Contributor

daavoo commented Oct 3, 2022

Examples of logging parameters in other frameworks:

@dberenbaum

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: frameworks Area: ML Framework integration enhancement p2-medium
Projects
None yet
Development

No branches or pull requests

3 participants