Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help text for dvc update #7958

Merged
merged 1 commit into from Jul 1, 2022
Merged

Help text for dvc update #7958

merged 1 commit into from Jul 1, 2022

Conversation

dberenbaum
Copy link
Contributor

Seems like the help text predated import-url, so expanded it to also include import-url updates.

@dberenbaum dberenbaum requested a review from a team as a code owner July 1, 2022 17:08
@dberenbaum dberenbaum requested a review from efiop July 1, 2022 17:08
@@ -28,7 +28,9 @@ def run(self):


def add_parser(subparsers, parent_parser):
UPDATE_HELP = "Update data artifacts imported from other DVC repositories."
UPDATE_HELP = (
"Update data artifact imported from an external DVC repository or URL."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be even better to be explicit - imported with dvc import or dvc import-url.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, do we put backticks by chance in the other places in help messages? (just to double check the conventions)?

@daavoo daavoo added the ui user interface / interaction label Jul 1, 2022
@daavoo daavoo merged commit c687d1b into main Jul 1, 2022
@daavoo daavoo deleted the update-help branch July 1, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants