Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: Expand flexible plots tests #7956

Open
daavoo opened this issue Jun 30, 2022 · 6 comments
Open

plots: Expand flexible plots tests #7956

daavoo opened this issue Jun 30, 2022 · 6 comments
Assignees
Labels
A: plots Related to the plots enhancement Enhances DVC testing Related to the tests and the testing infrastructure

Comments

@daavoo
Copy link
Contributor

daavoo commented Jun 30, 2022

Yes, its true. I will fix that in follow up PR, where I intend to parameterized this test to handle one use case per test. That way we won't have to create this huge repo_with_plots.
This specific use case (list of columns) is tested in tests/unit/render/test_vega_converter.py::test_converter - its a unit test but should be enough for now.

Originally posted by @pared in #7477 (comment)

@daavoo daavoo added A: plots Related to the plots testing Related to the tests and the testing infrastructure enhancement Enhances DVC labels Jun 30, 2022
@pared pared self-assigned this Jul 1, 2022
@pared
Copy link
Contributor

pared commented Jul 1, 2022

Aim of this issue is to parametrize tests in tests/integration/plots/test_plots.py, so that we have single use case per parameter set, and not testing few use cases at once, as we do now. That will allow us to test every expected plots set up with a test that is much easier to comprehend.

@pared
Copy link
Contributor

pared commented Jul 11, 2022

Need to test #8004 too

@pared
Copy link
Contributor

pared commented Aug 23, 2022

Include test for #8159

@dberenbaum
Copy link
Contributor

@daavoo What's still needed here?

@daavoo
Copy link
Contributor Author

daavoo commented Mar 16, 2023

@daavoo What's still needed here?

No idea off the top of my mind. I would need to take a look. At this point, I think most behaviors we care about are somehow tested in here or dvc-render or studio. But revisiting the tests would not hurt

@dberenbaum
Copy link
Contributor

Okay, feel free to close this one or take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Related to the plots enhancement Enhances DVC testing Related to the tests and the testing infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants