Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render: image_converter: Support slash in revision. #7937

Merged
merged 1 commit into from Jun 27, 2022
Merged

render: image_converter: Support slash in revision. #7937

merged 1 commit into from Jun 27, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Jun 27, 2022

Fixes #7934

@daavoo daavoo requested review from pared and mattseddon June 27, 2022 07:36
@daavoo daavoo requested a review from a team as a code owner June 27, 2022 07:36
@daavoo daavoo self-assigned this Jun 27, 2022
@daavoo daavoo added A: plots Related to the plots bugfix fixes bug product: VSCode Integration with VSCode extension labels Jun 27, 2022
@daavoo daavoo force-pushed the 7934-plots-diff-fails-when-given-a-revision-which-contains-a-path-separator branch from d77403c to dcdb436 Compare June 27, 2022 08:06
@daavoo daavoo force-pushed the 7934-plots-diff-fails-when-given-a-revision-which-contains-a-path-separator branch from b86a2c6 to 35e9634 Compare June 27, 2022 08:07
@pared pared merged commit c336507 into main Jun 27, 2022
@pared pared deleted the 7934-plots-diff-fails-when-given-a-revision-which-contains-a-path-separator branch June 27, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pared pared pared approved these changes

@mattseddon mattseddon mattseddon approved these changes

Assignees

@daavoo daavoo

Labels
A: plots Related to the plots bugfix fixes bug product: VSCode Integration with VSCode extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plots diff: fails when given a revision which contains a path separator
3 participants
@daavoo @pared @mattseddon