deps: bump dvc-data to 0.0.6; fix imports #7895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Jun 14, 2022
| @@ -6,9 +6,9 @@ | |||
| from dvc_data.db import get_index | |||
|
|
|||
| if TYPE_CHECKING: | |||
| from dvc_data.hashfile.db import HashFileDB | |||
There was a problem hiding this comment.
Changed ObjectDB type to HashFileDB here as it requires odb.verify. I didn't change it elsewhere as it seems we'll have few more iterations on this, and it's better to use stricter version (i.e. ObjectDB where possible).
skshetry
commented
Jun 14, 2022
Comment on lines
-414
to
-422
| def _add_suffix(objs: Set["HashFile"], suffix: str) -> None: | ||
| from itertools import chain | ||
|
|
||
| from dvc_data import iterobjs | ||
|
|
||
| for obj in chain.from_iterable(map(iterobjs, objs)): | ||
| if obj.name is not None: | ||
| obj.name += suffix | ||
|
|
There was a problem hiding this comment.
Gets rid of this functionality to set name. :)
efiop
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments.