run-cache: fix push from Windows to remote filesystems #7873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing paths with '\\' in the filename instead of posix paths to remote filesystems which was causing failures to upload. Although in some filesystems, this was failing silently, so upload would seem to have passed, but the download later would fail.
skshetry
added
p1-important
skshetry
commented
Jun 10, 2022
Comment on lines
+230
to
+231
| if not isinstance(to_fs, LocalFileSystem): | ||
| rel = from_fs.path.as_posix(rel) |
There was a problem hiding this comment.
@efiop, this shows that we really need to use posix paths everywhere.
There was a problem hiding this comment.
Hopefully this should be mitigated with run-cache object introduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were passing paths with
\\in the filename instead of posix paths toremote filesystems which were causing failures to upload.
Although in some filesystems, this was failing silently, so upload would seem
to have passed, but the download later would fail.