-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
readme: mention vs code extension #7859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few ideas:
- add badge (instead of donate - we don't need it and it's not very useful anyway)
- add link (section before badges)
- add a link in the line 26
- even more extreme add "in CLI (or VS code)" to the line 17
- mention in the installation section
Removed donate mentions in a separate PR: #7862. Did you have a particular badge in mind? For now, I added the version badge from https://github.com/cssho/VSMarketplaceBadge.
👍
Added for now. I worry the intro and "Why DVC?" become redundant. I would like to combine into a single bullet list in a separate PR.
Take a look if this is what you meant. Again, I worry a little about being too redundant. I think we should decide between adding it here or adding it in the bullets.
See what you think. |
README.rst
Outdated
|
||
|CI| |Maintainability| |Coverage| |Donate| |DOI| | ||
|CI| |Maintainability| |Coverage| |Donate| |VSCode| |DOI| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VS Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't accept whitespace. It's not visible anyway on the page, so I don't think it's an issue. Let me know if you think it's a problem.
It looks good to me, one small typo, otherwise I think it's good to go. I don't have any other major ideas and not sure anything else is needed.
I think it's fine to keep it redundant for now (for a few weeks) and we can cleanup it after. |
@shcheklein @jendefig Are there any important considerations for when this should be merged? |
@dberenbaum let's merge it Monday end of the day? (there is a merge conflict, and could you please resolve the open conversations - just to make sure that you saw the feedback :) ). |
f8691dc
to
ae4a263
Compare
Well I forgot this is rst and not md 🤦 . Please hold. |
@shcheklein tldr changed to |
Adds a couple of brief references to the VS Code extension.
Questions/issues to consider: