Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: smart legend labeling #7830

Closed
dberenbaum opened this issue May 31, 2022 · 5 comments
Closed

plots: smart legend labeling #7830

dberenbaum opened this issue May 31, 2022 · 5 comments
Labels
A: plots Related to the plots p2-medium Medium priority, should be done, but less important

Comments

@dberenbaum
Copy link
Contributor

Background:

After #7477, the legend can sometimes be too long. Removing the common parts of the legend would make it easier to read.

Also, in #7086, the y-axis isn't read from the column name even though the column name is the same in both files.

@dberenbaum dberenbaum added the A: plots Related to the plots label May 31, 2022
@dberenbaum
Copy link
Contributor Author

@pared It looks like this is already addressed in #7477?

@pared
Copy link
Contributor

pared commented Jun 20, 2022

Yes, it should be working now.

@pared
Copy link
Contributor

pared commented Jun 22, 2022

Though I still believe we should make a change in the plots templates to address @daavoo's idea

@dberenbaum
Copy link
Contributor Author

Closing in favor of iterative/dvc-render#83

@dberenbaum
Copy link
Contributor Author

Reopening since I think there are still improvements to make here. For example:

Screenshot 2022-11-21 at 3 45 29 PM

Some possible improvements:

  1. In the title, including the directory path might be useful, but I think we can omit the dvc.yaml filename. What other file could the configuration be coming from?
  2. In the legend, training/plots/metrics are the same for all entries, so can we omit it?
  3. The full rev is cut off but is actually training/plots/metrics/train/acc.tsv::train/acc. train/acc is redundant. One way to shorten it would be to omit the paths unless the field names conflict. Another would be to shorten the name in dvclive from train/acc to acc since train is already in the path (or log all dvclive metrics to one file).

@dberenbaum dberenbaum added the p2-medium Medium priority, should be done, but less important label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Related to the plots p2-medium Medium priority, should be done, but less important
Projects
None yet
Development

No branches or pull requests

2 participants