Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: open: Raise ValueError if rev is used in wrong mode. #7823

Merged
merged 2 commits into from Jun 15, 2022
Merged

api: open: Raise ValueError if rev is used in wrong mode. #7823

merged 2 commits into from Jun 15, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented May 27, 2022 •
edited

Closes #7405

@daavoo daavoo added the ui user interface / interaction label May 27, 2022
@daavoo daavoo requested a review from a team as a code owner May 27, 2022 11:03
@daavoo daavoo requested a review from pmrowla May 27, 2022 11:03
dberenbaum
dberenbaum reviewed May 27, 2022
View reviewed changes
dvc/api.py Show resolved Hide resolved
pmrowla
pmrowla suggested changes May 30, 2022
View reviewed changes
dvc/api.py Outdated Show resolved Hide resolved
@daavoo daavoo force-pushed the api-open-valueerror branch 2 times, most recently from 4745b9d to ad7fb11 Compare May 30, 2022 15:12
@daavoo daavoo requested review from dberenbaum and pmrowla May 30, 2022 15:12
@daavoo daavoo added the enhancement Enhances DVC label May 30, 2022
pmrowla
pmrowla approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@pmrowla pmrowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes LGTM, this can be merged as soon as the docstring discussions are settled

@daavoo daavoo self-assigned this May 31, 2022
@skshetry
Copy link
Member

skshetry commented Jun 13, 2022 •
edited

@daavoo, please split the PR, the docs changes are unrelated to the bugfix.

daavoo and others added 2 commits June 15, 2022 17:15
@daavoo daavoo enabled auto-merge (rebase) June 15, 2022 15:15
@daavoo daavoo disabled auto-merge June 15, 2022 16:05
@daavoo daavoo enabled auto-merge (rebase) June 15, 2022 16:08
@daavoo daavoo merged commit 1663b97 into main Jun 15, 2022
@daavoo daavoo deleted the api-open-valueerror branch June 15, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrowla pmrowla pmrowla approved these changes

@dberenbaum dberenbaum dberenbaum approved these changes

Assignees

@daavoo daavoo

Labels
enhancement Enhances DVC ui user interface / interaction
Projects
No open projects
DVC
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api.open: Write mode doesn't work with rev argument
4 participants
@daavoo @skshetry @pmrowla @dberenbaum