plots: Pass templates_dir to match_renderers.

[daavoo]

We were forgetting to pass the default template dir.

Fixes #7817.

• ❗ I have followed the Contributing to DVC checklist.

• 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.

[dberenbaum]

@daavoo I'm still getting the same error from #7817. Am I missing something?

$ dvc plots show -v -t custom
2022-05-27 11:06:40,087 ERROR: unexpected error - Template 'custom' not found.
------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/dave/Code/dvc/dvc/cli/__init__.py", line 185, in main
    ret = cmd.do_run()
  File "/Users/dave/Code/dvc/dvc/cli/command.py", line 22, in do_run
    return self.run()
  File "/Users/dave/Code/dvc/dvc/commands/plots.py", line 77, in run
    renderers = match_renderers(
  File "/Users/dave/Code/dvc/dvc/render/match.py", line 57, in match_renderers
    renderer_class(datapoints, filename, **plot_properties)
  File "/Users/dave/miniforge3/envs/dvc/lib/python3.10/site-packages/dvc_render/vega.py", line 37, in __init__
    self.template = get_template(
  File "/Users/dave/miniforge3/envs/dvc/lib/python3.10/site-packages/dvc_render/vega_templates.py", line 562, in get_template
    raise TemplateNotFoundError(template)
dvc_render.vega_templates.TemplateNotFoundError: Template 'custom' not found.
------------------------------------------------------------
2022-05-27 11:06:41,078 DEBUG: Version info for developers:
DVC version: 2.10.3.dev94+g069ef835c
---------------------------------
Platform: Python 3.10.2 on macOS-12.3.1-arm64-arm-64bit
Supports:
        azure (adlfs = 2022.4.0, knack = 0.9.0, azure-identity = 1.7.1),
        gdrive (pydrive2 = 1.10.1),
        gs (gcsfs = 2022.5.0),
        hdfs (fsspec = 2022.5.0, pyarrow = 7.0.0),
        webhdfs (fsspec = 2022.5.0),
        http (aiohttp = 3.8.1, aiohttp-retry = 2.4.5),
        https (aiohttp = 3.8.1, aiohttp-retry = 2.4.5),
        s3 (s3fs = 2022.5.0, boto3 = 1.21.21),
        ssh (sshfs = 2022.3.1),
        oss (ossfs = 2021.8.0),
        webdav (webdav4 = 0.9.4),
        webdavs (webdav4 = 0.9.4)
Cache types: <https://error.dvc.org/no-dvc-cache>
Caches: local
Remotes: https
Workspace directory: apfs on /dev/disk3s1s1
Repo: dvc, git

Having any troubles? Hit us up at https://dvc.org/support, we are always happy to help!
2022-05-27 11:06:41,079 DEBUG: Analytics is disabled.

[daavoo]

@daavoo I'm still getting the same error from #7817. Am I missing something?

I missed an extra s in templates_dir in dvc_render 🤦 . Will adjust here to use template_dir

[skshetry]

Both of these tests are not useful. I'll suggest testing actual behaviour instead if you can or get rid of them.

[daavoo]

Both of these tests are not useful.

@skshetry Could you elaborate on why are not useful?

I'll suggest testing actual behaviour instead if you can or get rid of them.

Behavior is tested in https://github.com/iterative/dvc-render/blob/main/tests/test_templates.py#L39

[skshetry]

Also, it'd be better to push more of this logic inside the API so that you can test them easily.

[daavoo]

Sorry for my lack of understanding, could you elaborate on what does "the API" refers to?

[daavoo]

@dberenbaum This works for me, could you try with latest version?

[daavoo]

Will address test comments in separate P.R. after clarification