Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp: output troubleshooting link on shallow merge failure #7791

Merged
merged 1 commit into from Jun 2, 2022

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented May 20, 2022

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Will close #7547

Depends on iterative/scmrepo#75

$ dvc exp run
ERROR: Merge analysis failed: Cannot merge in shallow Git repo. See <https://dvc.org/doc/user-guide/troubleshooting#git-shallow> for more information.

@pmrowla pmrowla added ui user interface / interaction A: experiments Related to dvc exp labels May 20, 2022
@pmrowla pmrowla self-assigned this May 20, 2022
dvc/scm.py Outdated Show resolved Hide resolved
@pmrowla pmrowla marked this pull request as ready for review June 2, 2022 07:43
@pmrowla pmrowla requested a review from a team as a code owner June 2, 2022 07:43
@pmrowla pmrowla requested a review from skshetry June 2, 2022 07:43
@pmrowla pmrowla merged commit 1cc803d into iterative:main Jun 2, 2022
@pmrowla pmrowla deleted the 7547-merge-shallow branch June 2, 2022 08:15
def __init__(self, msg: str, scm: Optional["Git"] = None) -> None:
if scm and self._is_shallow(scm):
url = format_link(
"https://dvc.org/doc/user-guide/troubleshooting#git-shallow"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmrowla, we have a shortlink to troubleshooting:

Suggested change
"https://dvc.org/doc/user-guide/troubleshooting#git-shallow"
"https://error.dvc.org/git-shallow"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you can use error_link("git-shallow") instead of format_link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc exp run unavailable in CML
4 participants