exp: speed up repro execution with untracked directories in workspace #7786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
force-pushed
the
feature/speed-up-repro
branch
from
acaa822
to
9b475d7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
dtrifiro
force-pushed
the
feature/speed-up-repro
branch
3 times, most recently
from
77c1207
to
5add9bc
Compare
dtrifiro
force-pushed
the
feature/speed-up-repro
branch
from
5add9bc
to
df3463a
Compare
When large untracked directories are present in the workspace, a lot of time is spent collecting untracked files in `scm.status` and `scm.is_dirty`.
dtrifiro
force-pushed
the
feature/speed-up-repro
branch
from
df3463a
to
a089963
Compare
pmrowla
approved these changes
Jun 7, 2022
skshetry
reviewed
Jul 20, 2022
Comment on lines
+401
to
402
| staged, _, _ = self.scm.status(untracked_files="no") | ||
| if staged: |
There was a problem hiding this comment.
While having some discussions related to using pygit2 for status for performance reasons with @dtrifiro, I noticed that this is equivalent to git diff --staged --quiet. So, this is equivalent to following:
Suggested change
| staged, _, _ = self.scm.status(untracked_files="no") | |
| if staged: | |
| if self.scm.pygit2.repo.diff(cached=True): |
Leaving comment for posterity's sake. The performance with dulwich + untracked_files is good enough and is comparable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When large untracked directories are present in the workspace, a lot of time is spent collecting untracked files in
scm.statusandscm.is_dirty(which also callsstatus).scmrepo==0.0.23addsuntracked_files=noflag which avoids collecting untracked files.