Catch correct exception class in params.show() #7750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
reviewed
May 16, 2022
| @@ -117,8 +119,8 @@ def show(repo, revs=None, targets=None, deps=False, onerror: Callable = None): | |||
| # Hide workspace params if they are the same as in the active branch | |||
| try: | |||
| active_branch = repo.scm.active_branch() | |||
| except (TypeError, NoSCMError): | |||
| # TypeError - detached head | |||
| except (SCMError, NoSCMError): | |||
There was a problem hiding this comment.
I think this may still get raised on a gitpython backend, which probably should be handled upstream.
There was a problem hiding this comment.
You have this construction in metrics.show() too, and it doesn't have TypeError there.
There was a problem hiding this comment.
BTW, maybe moving this to commands code will improve code - this feels like a presentation logic.
pmrowla
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.