Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dag: fix dot file rendering order. #7725

Merged
merged 2 commits into from May 11, 2022
Merged

dag: fix dot file rendering order. #7725

merged 2 commits into from May 11, 2022

Conversation

tirkarthi
Copy link
Contributor

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Closes #7676

@tirkarthi tirkarthi requested a review from a team as a code owner May 11, 2022 10:11
@tirkarthi tirkarthi requested a review from dtrifiro May 11, 2022 10:11
@tirkarthi
Copy link
Contributor Author

  • Before PR

normal

  • After PR

reverse

The PR makes the output consistent with mermaid option output as seen below :

dvc/commands/dag.py Outdated Show resolved Hide resolved
Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix test

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not strictly in the scope of the P.R. but would be a good occasion to add a --dot example output in https://dvc.org/doc/command-reference/dag

$ dvc dag --dot
strict digraph  {
prepare;
featurize;
train;
evaluate;
"data/data.xml.dvc";
prepare -> featurize;
featurize -> train;
featurize -> evaluate;
train -> evaluate;
"data/data.xml.dvc" -> prepare;
}

@tirkarthi
Copy link
Contributor Author

@daavoo Thanks, the page also seems to be missing options like mermaid and markdown. I will update the docs.

  --mermaid        Print DAG with mermaid format.
  --md, --show-md  Print DAG with mermaid format wrapped in Markdown
                   block.

@daavoo
Copy link
Contributor

daavoo commented May 11, 2022

@daavoo Thanks, the page also seems to be missing options like mermaid and markdown. I will update the docs.

  --mermaid        Print DAG with mermaid format.
  --md, --show-md  Print DAG with mermaid format wrapped in Markdown
                   block.

For mermaid/markdown there is an open P.R. (iterative/dvc.org#3454) but for the rest would be great πŸ™Œ

@tirkarthi
Copy link
Contributor Author

Windows test failure seems unrelated to the PR. It fails even after rebase with master and rerun.

tirkarthi and others added 2 commits May 11, 2022 15:10
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
@efiop efiop added the bugfix fixes bug label May 11, 2022
@efiop efiop merged commit 3faf413 into iterative:main May 11, 2022
@efiop
Copy link
Member

efiop commented May 11, 2022

Thank you, @tirkarthi ! πŸ™

@tirkarthi
Copy link
Contributor Author

Thanks @Ruslan and @daavoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc dag --dot: Reverse order
3 participants