New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dag: fix dot file rendering order. #7725
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not strictly in the scope of the P.R. but would be a good occasion to add a --dot
example output in https://dvc.org/doc/command-reference/dag
$ dvc dag --dot
strict digraph {
prepare;
featurize;
train;
evaluate;
"data/data.xml.dvc";
prepare -> featurize;
featurize -> train;
featurize -> evaluate;
train -> evaluate;
"data/data.xml.dvc" -> prepare;
}
@daavoo Thanks, the page also seems to be missing options like mermaid and markdown. I will update the docs.
|
For mermaid/markdown there is an open P.R. (iterative/dvc.org#3454) but for the rest would be great π |
Windows test failure seems unrelated to the PR. It fails even after rebase with master and rerun. |
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
Thank you, @tirkarthi ! π |
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π
Closes #7676