exp init: fixes #7534; simplifies/updates exp init --live #7703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dberenbaum
requested review from
pmrowla,
daavoo and
skshetry
and removed request for
pmrowla
daavoo
reviewed
May 5, 2022
daavoo
reviewed
May 5, 2022
|
Okay, tests are ready. Sorry, should have put in draft mode/held off on assigning you. |
daavoo
reviewed
May 5, 2022
Added. |
daavoo
approved these changes
May 5, 2022
skshetry
reviewed
May 9, 2022
skshetry
reviewed
May 9, 2022
skshetry
reviewed
May 9, 2022
There was a problem hiding this comment.
@dberenbaum, changes look good to me. I have 2 suggestions above. I can also handle if needed, lmk. 🙂
Thanks! Updated the PR. |
skshetry
approved these changes
May 9, 2022
Comment on lines
194
to
+195
| "--type", | ||
| choices=["default", "dl"], | ||
| choices=["default", "checkpoint"], |
There was a problem hiding this comment.
Needs doc update 🙂 (at least in exp init --type ref.)
skshetry
added
enhancement
This was referenced Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to fix tests, but I thought this might be easier than explaining the changes correctly.