FileSystem: handle encoding via kwargs.
#7694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
force-pushed
the
base-fs-encoding
branch
2 times, most recently
from
21e6bca
to
50a7f76
Compare
daavoo
commented
May 4, 2022
skshetry
reviewed
May 4, 2022
Drop if None. Closes #7691
skshetry
approved these changes
May 4, 2022
efiop
changed the title
encoding via kwargs.encoding via kwargs.
efiop
reviewed
May 4, 2022
Comment on lines
+184
to
+185
| if "b" in mode: | ||
| kwargs.pop("encoding", None) |
There was a problem hiding this comment.
Hm, why do we even need to pop it? In the #7691 we are not even getting the encoding here.
There was a problem hiding this comment.
RepoFS and DvcFS always sends encoding=None to the filesystems even in binary mode. open() is not fsspec compliant and can be fixed at that time in other filesystems. For now, I think this is the simplest approach.
There was a problem hiding this comment.
Let's fix repofs/dvcfs then if that is not too much work. Seems like it is a simple arg adjustment. Unless I'm missing something.
There was a problem hiding this comment.
I'd still try to avoid this bug here even if we fix repofs/dvcfs, until we fix this on fsspec's side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7691