Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on sync when there is no match for glob. #7687

Merged
merged 6 commits into from May 11, 2022
Merged

Fail on sync when there is no match for glob. #7687

merged 6 commits into from May 11, 2022

Conversation

tirkarthi
Copy link
Contributor

@tirkarthi tirkarthi commented May 3, 2022 •
edited by efiop

Closes #7492

@tirkarthi tirkarthi requested a review from a team as a code owner May 3, 2022 12:23
@tirkarthi tirkarthi requested a review from efiop May 3, 2022 12:23
@tirkarthi tirkarthi mentioned this pull request May 3, 2022
Closed
daavoo
daavoo reviewed May 5, 2022
View reviewed changes
dvc/repo/pull.py Outdated Show resolved Hide resolved
daavoo
daavoo reviewed May 6, 2022
View reviewed changes
tests/func/test_import.py Outdated Show resolved Hide resolved
tirkarthi and others added 2 commits May 7, 2022 00:45
@tirkarthi @daavoo
Update tests/func/test_data_cloud.py
9f5cb58 
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
68a1883 
for more information, see https://pre-commit.ci
efiop
efiop reviewed May 6, 2022
View reviewed changes
tests/func/test_add.py Outdated Show resolved Hide resolved
efiop
efiop reviewed May 6, 2022
View reviewed changes
dvc/exceptions.py Outdated Show resolved Hide resolved
efiop
efiop approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tirkarthi ! 🙏

@efiop efiop merged commit b8d7382 into iterative:main May 11, 2022
@efiop efiop added bugfix fixes bug A: api Related to the dvc.api labels May 11, 2022
@tirkarthi
Copy link
Contributor Author

Thanks @efiop and @daavoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daavoo daavoo daavoo left review comments

@efiop efiop efiop approved these changes

Assignees
No one assigned
Labels
A: api Related to the dvc.api bugfix fixes bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

push/pull: globs that match no targets should fail
3 participants
@tirkarthi @efiop @daavoo