plots: image converter return absolute paths #7664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daavoo
reviewed
May 3, 2022
Comment on lines
-70
to
76
| assert ( | ||
| os.path.join("dvc_plots", "static", f"{version}_{filename}") | ||
| in html_content | ||
| ) | ||
| assert os.path.join("static", f"{version}_{filename}") in html_content | ||
|
|
||
| # there should be no absolute paths in produced HTML | ||
| assert str(tmp_dir) not in html_content | ||
| # TODO uncomment once dvc-render is adjusted | ||
| # assert str(tmp_dir) not in html_content | ||
| assert ( | ||
| tmp_dir / "dvc_plots" / "static" / f"{version}_{filename}" |
There was a problem hiding this comment.
Does this belong to integration tests? HTML content is not really used by vscode, right?
There was a problem hiding this comment.
This is true, currently I implemented html checks to make sure everything works as expected. In further work we will need to split that. I am thinking how to do it without too much test duplication.
pared
changed the title
|
As iterative/dvc-render#39 takes a bit of discussion I think we should merge this one. Even if its not desired behavior, it works at least, contrary to the current |
daavoo
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
In #7549 we rolled back to the behavior of writing images, instead of encoding them. I made it DVC's responsibility to provide proper path to the renderer. However, without knowing where we create HTML, it is impossible to do that. We need to modify
dvc-renderto be able to evaluate relative paths of the images. Marking as WIP, as we need a fix ondvc-renderside first and a release.