Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvcfile: preserve 'remote' on add and commit #7618

Merged
merged 1 commit into from May 5, 2022

Conversation

SamKnightGit
Copy link

@SamKnightGit SamKnightGit commented Apr 22, 2022

Fixes partially #7356 -- dvc move doesn't preserve many fields (description, remote, comments) but looks like a more involved change.

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Preserves 'remote' output on dvc add and dvc commit.

Fixes iterative#7356
@SamKnightGit SamKnightGit requested a review from a team as a code owner April 22, 2022 10:33
@SamKnightGit SamKnightGit requested a review from pared April 22, 2022 10:33
@skshetry skshetry self-requested a review April 23, 2022 01:04
Copy link
Contributor

@karajan1001 karajan1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pared pared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @skshetry should we wait for your review?

@SamKnightGit
Copy link
Author

Any idea if/when we can get this change bundled into a release? It's currently blocking my team's use case for dvc (multiple remotes). Thanks guys

@skshetry
Copy link
Member

skshetry commented May 5, 2022

Thankyou @SamKnightGit.

@skshetry skshetry merged commit 1f5f2f5 into iterative:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants