Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc ls: not raise PathMissingError on empty dir. #6120

Merged
merged 1 commit into from May 11, 2022

Conversation

karajan1001
Copy link
Contributor

fix #5841

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

tests/func/test_ls.py Outdated Show resolved Hide resolved
@karajan1001 karajan1001 added this to In progress in DVC 15 - 29 June 2021 via automation Jun 15, 2021
@karajan1001 karajan1001 self-assigned this Jun 15, 2021
@karajan1001 karajan1001 requested a review from efiop June 17, 2021 12:37
@karajan1001 karajan1001 moved this from In progress to Review in progress in DVC 15 - 29 June 2021 Jun 22, 2021
@karajan1001 karajan1001 removed this from Review in progress in DVC 15 - 29 June 2021 Jun 29, 2021
@karajan1001 karajan1001 added this to In progress in DVC 29 June - 12 July 2021 via automation Jun 29, 2021
@karajan1001 karajan1001 moved this from In progress to Review in progress in DVC 29 June - 12 July 2021 Jun 29, 2021
@karajan1001 karajan1001 removed this from Review in progress in DVC 29 June - 12 July 2021 Jul 13, 2021
@karajan1001 karajan1001 added this to In progress in DVC 13 July - 26 July 2021 via automation Jul 13, 2021
@karajan1001 karajan1001 moved this from In progress to Review in progress in DVC 13 July - 26 July 2021 Jul 13, 2021
@karajan1001 karajan1001 removed this from Review in progress in DVC 13 July - 26 July 2021 Jul 27, 2021
@karajan1001 karajan1001 added this to In progress in DVC 27 Jul - 10 Aug via automation Jul 27, 2021
@karajan1001 karajan1001 moved this from In progress to Review in progress in DVC 27 Jul - 10 Aug Jul 27, 2021
@karajan1001 karajan1001 removed this from Review in progress in DVC 27 Jul - 10 Aug Aug 10, 2021
@karajan1001 karajan1001 added this to In progress in DVC 10 Aug - 24 Aug 2021 via automation Aug 10, 2021
@karajan1001 karajan1001 moved this from In progress to Review in progress in DVC 10 Aug - 24 Aug 2021 Aug 10, 2021
@karajan1001 karajan1001 removed this from Review in progress in DVC 10 Aug - 24 Aug 2021 Aug 24, 2021
@karajan1001 karajan1001 added this to In progress in DVC 24 Aug - 07 Sep 2021 via automation Aug 24, 2021
@karajan1001 karajan1001 moved this from In progress to Review in progress in DVC 24 Aug - 07 Sep 2021 Aug 24, 2021
@karajan1001 karajan1001 removed this from Review in progress in DVC 24 Aug - 07 Sep 2021 Aug 24, 2021
@dberenbaum
Copy link
Contributor

@karajan1001 @efiop Is there a plan to return to this PR after dvc-data work?

@efiop
Copy link
Member

efiop commented Feb 18, 2022

@dberenbaum Even earlier. After #7384 Thanks for the heads up!

@dberenbaum
Copy link
Contributor

@efiop Is this one ready for review now?

@karajan1001 karajan1001 requested a review from a team as a code owner May 5, 2022 09:39
@karajan1001 karajan1001 added A: data-management Related to dvc add/checkout/commit/move/remove bugfix fixes bug labels May 10, 2022
@efiop efiop merged commit 09afd2a into iterative:main May 11, 2022
@karajan1001 karajan1001 deleted the fix5841 branch May 11, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: data-management Related to dvc add/checkout/commit/move/remove bugfix fixes bug
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

dvc list: Error on empty directory.
3 participants