Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly Digest (9 February, 2020 - 16 February, 2020) #3342

Closed
weekly-digest bot opened this issue Feb 16, 2020 · 0 comments
Closed

Weekly Digest (9 February, 2020 - 16 February, 2020) #3342

weekly-digest bot opened this issue Feb 16, 2020 · 0 comments

Comments

@weekly-digest
Copy link

weekly-digest bot commented Feb 16, 2020

Here's the Weekly Digest for iterative/dvc:

ISSUES

Last week 51 issues were created.
Of these, 31 issues have been closed and 20 issues are still open.

OPEN ISSUES

💚 #3340 it should be clear from logs (dvc smth -v) what command does it run, by shcheklein
💚 #3339 Error when re-importing a renamed directory, by charlesbaynham
💚 #3338 Incorrect error message when importing to non-existent folder, by charlesbaynham
💚 #3335 [draft] ui: fix missing progress & tidy, by casperdcl
💚 #3332 missing progress, by casperdcl
💚 #3322 term: avoid "under X control", by jorgeorpinel
💚 #3319 S3 support for data storage, by pinkmanbox
💚 #3318 MacOs and Windows lowercases filenames, by pared
💚 #3317 remove: change default behaviour to --purge, port back patch from 1.0 branch, by jorgeorpinel
💚 #3315 git: quote filenames at remind_to_track, by mroutis
💚 #3313 perf: checkout: subsequent runs slow, by casperdcl
💚 #3311 term: (MD5) "checksum" -> "file hash" or "hash value"?, by jorgeorpinel
💚 #3309 get/import: retrieve files inside directory outs, by mroutis
💚 #3308 get/import: updates output strings, et al., by jorgeorpinel
💚 #3306 logger: refactor, remove dead code, by mroutis
💚 #3305 import: allow chaining imports somehow? (except circular), by jorgeorpinel
💚 #3303 dvc add print not quote-wrapped file-paths if they contain spaces, by byaka
💚 #3302 term: replace "working tree/dir" for "workspace"? (where appropriate), by jorgeorpinel
💚 #3300 dvc cache dir: carry over the existing cache, by dmpetrov
💚 #3291 Specify directory to hold dvc files, by vernt

CLOSED ISSUES

❤️ #3337 update: support specifying revision when updating, by skshetry
❤️ #3336 dvc update after importing an older version of a file, by andronovhopf
❤️ #3334 ui: fix missing progress & tidy, by casperdcl
❤️ #3333 schema: use a more flexible hash schema, by efiop
❤️ #3331 DVC does fails when the md5 hash contains only numbers, by charlesbaynham
❤️ #3330 snap: test: add build and deploy checks, by casperdcl
❤️ #3329 dvc: do not set cache dir if it's not a dvc repo, by skshetry
❤️ #3328 dvc commands fail on non-DVC repository with an exception, by skshetry
❤️ #3327 tests: fix typo on gdrive_client_secret, by skshetry
❤️ #3326 checkout: change loglevel to debug and simplify message, by skshetry
❤️ #3325 logger: log datetime when on debug mode, by skshetry
❤️ #3324 daemon config fix, by pared
❤️ #3323 erepo: fix known sha handling, by Suor
❤️ #3321 repo: Prevent repo from setting log level, by gauravr
❤️ #3320 [DO NOT MERGE] test lowercase name overlapping, by pared
❤️ #3316 ui: make progress bars respect --quiet, by casperdcl
❤️ #3314 dvc push -q is not completely quiet, shows file transfer tqdm progress bars, by WillNichols726
❤️ #3312 imp_url: make default stage fname accompany import target, by pared
❤️ #3310 Restyle get/import: retrieve files inside directory outs, by restyled-io[bot]
❤️ #3307 black: bump version 19.3b0 -> 19.10b0, by mroutis
❤️ #3304 import: behave like add, move, by jorgeorpinel
❤️ #3301 repro: fix bug in _get_active_graph, by efiop
❤️ #3299 diff: use rev instead of ref, by efiop
❤️ #3298 dvc: refactor config, by Suor
❤️ #3297 checkout: fix output message, by skshetry
❤️ #3296 add: meaningful message upon adding overlapping paths, by pared
❤️ #3295 repo: raise exception if root_dir is not a directory path, by skshetry
❤️ #3294 GDrive improvements and code cleanup, by shcheklein
❤️ #3293 [WIP] GDrive code cleanup, by shcheklein
❤️ #3292 analytics: ignore request.post errors, by efiop
❤️ #3290 logger: allow exc_info in all record types, by efiop

LIKED ISSUE

👍 #3304 import: behave like add, move, by jorgeorpinel
It received 👍 x4, 😄 x0, 🎉 x0 and ❤️ x0.

NOISY ISSUE

🔈 #3299 diff: use rev instead of ref, by efiop
It received 9 comments.

PULL REQUESTS

Last week, 35 pull requests were created, updated or merged.

UPDATED PULL REQUEST

Last week, 9 pull requests were updated.
💛 #3335 [draft] ui: fix missing progress & tidy, by casperdcl
💛 #3322 term: avoid "under X control", by jorgeorpinel
💛 #3315 git: quote filenames at remind_to_track, by mroutis
💛 #3309 get/import: retrieve files inside directory outs, by mroutis
💛 #3308 get/import: updates output strings, et al., by jorgeorpinel
💛 #3306 logger: refactor, remove dead code, by mroutis
💛 #3269 [WIP] gdrive: support Google Service accounts, by MaxRis
💛 #3257 SCM: allow multiple DVC repos inside single SCM repo, by pared
💛 #3207 [WIP] gc: change option to use single remove flags, by skshetry

MERGED PULL REQUEST

Last week, 26 pull requests were merged.
💜 #3337 update: support specifying revision when updating, by skshetry
💜 #3333 schema: use a more flexible hash schema, by efiop
💜 #3330 snap: test: add build and deploy checks, by casperdcl
💜 #3329 dvc: do not set cache dir if it's not a dvc repo, by skshetry
💜 #3327 tests: fix typo on gdrive_client_secret, by skshetry
💜 #3326 checkout: change loglevel to debug and simplify message, by skshetry
💜 #3325 logger: log datetime when on debug mode, by skshetry
💜 #3324 daemon config fix, by pared
💜 #3323 erepo: fix known sha handling, by Suor
💜 #3321 repo: Prevent repo from setting log level, by gauravr
💜 #3316 ui: make progress bars respect --quiet, by casperdcl
💜 #3312 imp_url: make default stage fname accompany import target, by pared
💜 #3307 black: bump version 19.3b0 -> 19.10b0, by mroutis
💜 #3301 repro: fix bug in _get_active_graph, by efiop
💜 #3299 diff: use rev instead of ref, by efiop
💜 #3298 dvc: refactor config, by Suor
💜 #3296 add: meaningful message upon adding overlapping paths, by pared
💜 #3295 repo: raise exception if root_dir is not a directory path, by skshetry
💜 #3294 GDrive improvements and code cleanup, by shcheklein
💜 #3292 analytics: ignore request.post errors, by efiop
💜 #3290 logger: allow exc_info in all record types, by efiop
💜 #3288 gdrive: add gc command support, by MaxRis
💜 #3286 erepo: cache all read only external repos by hexsha, by Suor
💜 #3277 get/import: they don't work with any DVC project, only DVC repos (as well as Git repos), by jorgeorpinel
💜 #3246 introduce dvc list command, by JIoJIaJIu
💜 #2975 add: auto convert absolute_path => relative, by casperdcl

COMMITS

Last week there were 32 commits.
🛠️ [update: support specifying revision when updating (#3337) * update: work with rev

Fixes #3314

  • ui: catch remaining missing auto-quiet progress

  • progress: treat disable=False as None

  • test: progress.Tqdm(disable=False)

  • revert no_progress_bar=None <= False

partially reverts e0342a8](276a2b0) by casperdcl
🛠️ dvc: do not set cache dir if not a dvc repo (#3329) by skshetry
🛠️ [snap: test: add build and deploy checks (#3330) * snap: deploy: include review-tools

Enables pre-deployment checks

  • snap: build: include snapd

Enables enhanced build-time checks](6932cf6) by casperdcl
🛠️ imp_url: make default stage fname accompany import target (#3312) by pared
🛠️ tests: fix typo on gdrive_client_secret (#3327) by skshetry
🛠️ checkout: change level to debug and fix message (#3326) by skshetry
🛠️ logger: log datetime when on debug mode (#3325) by skshetry
🛠️ daemon config fix (#3324) by pared
🛠️ erepo: fix known sha handling (#3323) Closes #3280. by Suor
🛠️ [repo: Prevent repo from setting log level (#3321) * Removed setting log level

Advantages:

  • read like a dict

  • modify as a dict for testing or manipulation purposes

  • wrap modifications into context manager to save them:

    with config.edit("local") as conf:
    conf["core"]["remote"] = "new-default"

Design decisions:

  • dropped string constants
  • remote sections are parsed into a simple subdict upon load
  • remote config schema is now defined by url scheme
  • relative paths are handled transparently upon load/save
  • user config and remote manipulations are moved to commands
  • same dev manipulations are done by simply modifying a config dict

So we have 3 things cached now separately:

  • clean clones, to not ask for creds repatedly
  • cache dirs, also shared between erepos with same origin
  • checked out clones if they are read only, addressed by (url, hexsha)

Several additions to Git along the way:

  • Git.is_sha() static method
  • .pull() and .push() work with multiple returned records correctly
  • .get_rev() and .resolve_rev() work faster
  • .resolve_rev() looks for remote branches
  • .has_rev()

Fixes #3280.

  • git: improve .resolve_rev()

It follows git checkout logic now - if name can be unambiguously
resolved across known remotes then it's done.](47081cb) by Suor
🛠️ [GDrive improvements and code cleanup (#3294) * cleanup gdrive code, fix remote ids resolving

  • fixes after testing GDrive cleanup

  • address CodeClimate complexity, simplify a litte bit

  • address CodeClimate complexity, further simplify complexity

  • further refactoring need to fix GDrive tests

  • tests: minor setup gdrive cloud simplification](5e98a70) by shcheklein
    🛠️ [repro: fix bug in _get_active_graph (repro: fix bug in _get_active_graph #3301) We are currently removing all of the deps stages from the DAG even if
    those deps are referenced by some parallel branches of execution.
    The new approach is to remove edges and then gradually remove nodes if
    there are no more in edges left.

Discord context:
https://discordapp.com/channels/485586884165107732/485596304961962003/676464313942409265](https://github.com/iterative/dvc/commit/2361bceb703f0e43dfca6e3d4fe3685c81a0cfd1) by efiop
🛠️ diff: use rev instead of ref (#3299) Fixes #3245 by efiop
🛠️ [repo: raise exception if root_dir is not a directory path (#3295) * repo: throw if root_dir in Repo.init() is not a directory path

When Repo is instantiated with invalid urls such as 'http://github.com/iterative/dvc.git',
it does os.path.realpath which is not intelligent enough and just concatenates with current
working directory, which is then traversed outward. It might happen that the outward folder
is a dvc directory which is not really what we want.

So, a check for root to be a directory is added. Otherwise, NotDvcRepoError is thrown with
a custom message.

This also fixes annoying redundant newline between traceback and "need
any help" footer.](2786a4e) by efiop
🛠️ deps: update pydrive2 version by efiop
🛠️ dvc: bump to 0.82.10 by efiop
🛠️ gdrive: add gc command support (#3288) by MaxRis

CONTRIBUTORS

Last week there were 11 contributors.
👤 skshetry
👤 efiop
👤 casperdcl
👤 pared
👤 Suor
👤 gauravr
👤 JIoJIaJIu
👤 mroutis
👤 shcheklein
👤 jorgeorpinel
👤 MaxRis

STARGAZERS

Last week there were 48 stagazers.
⭐ chrdiller
⭐ egemenzeytinci
⭐ jasonzdeng
⭐ EverLookNeverSee
⭐ xduan7
⭐ pmrowla
⭐ badran047
⭐ orangle
⭐ sklarsa
⭐ OzakIOne
⭐ limdauto
⭐ GregHilston
⭐ svenhaile
⭐ ComplicatedPhenomenon
⭐ taka-wang
⭐ kaemo
⭐ chadykamar
⭐ acastrops
⭐ nantrinh
⭐ infosmith
⭐ dhruvrnaik
⭐ sirvincent
⭐ ChiragSehra
⭐ jorgeih
⭐ sokoloff
⭐ timokratia
⭐ pvanhaes
⭐ astrocumbia
⭐ gyf304
⭐ remi-nd
⭐ pratikfalke
⭐ sakshamio
⭐ SamuelKupferschmid
⭐ nmacri
⭐ cmasch
⭐ chenrui333
⭐ alexkyllo
⭐ Jay-Jay-D
⭐ j718
⭐ datadeity
⭐ jin717
⭐ halidaltuner
⭐ antoine-briand
⭐ pstanisl
⭐ hXtreme
⭐ denisb411
⭐ mremes
⭐ rgreenjr
You all are the stars! 🌟

RELEASES

Last week there were 4 releases.
🚀 0.85.0 0.85.0
🚀 0.84.0 0.84.0
🚀 0.83.0 0.83.0
🚀 0.82.10 0.82.10

That's all for last week, please 👀 Watch and ⭐ Star the repository iterative/dvc to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shcheklein