Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: support pre-commit util #3271

Closed
efiop opened this issue Feb 1, 2020 · 2 comments · Fixed by #3406
Closed

install: support pre-commit util #3271

efiop opened this issue Feb 1, 2020 · 2 comments · Fixed by #3406
Assignees
@efiop
Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
DVC 10 - 24 March 2020

Comments

@efiop
Copy link
Member

efiop commented Feb 1, 2020 •
edited

So far looks like we only need pre-commit to add support for post-checkout hook. Authors are ok with implementing it pre-commit/pre-commit#1120 and the implementation is pretty straightforward. Might consider contributing that to provide the best experience for the users (as our dvc hooks get into conflict with out pre-commit hooks already).
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Feb 1, 2020
@efiop efiop added enhancement Enhances DVC ui user interface / interaction labels Feb 1, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Feb 1, 2020
@weekly-digest weekly-digest bot mentioned this issue Feb 2, 2020
Closed
@efiop efiop added the p2-medium Medium priority, should be done, but less important label Feb 13, 2020
@andrewhare
Copy link
Contributor

I'm beginning work on this ticket now.

@andrewhare
Copy link
Contributor

I've written up two PRs for pre-commit:

@andrewhare andrewhare mentioned this issue Feb 25, 2020
Merged
@fferegrino fferegrino mentioned this issue Mar 14, 2020
Closed
@efiop efiop self-assigned this Mar 16, 2020
@efiop efiop added this to To do in DVC 10 - 24 March 2020 via automation Mar 16, 2020
@efiop efiop moved this from To do to Done in DVC 10 - 24 March 2020 Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efiop efiop

Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
No open projects
DVC 10 - 24 March 2020
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pre-commit for Git hooks andrewhare/dvc
2 participants
@andrewhare @efiop