@itavero What about utilizing motor_state for PositionState on devices that support it?

So we're only updating CurrentPosition when motor_state != idle, and in cases where the command didn't come from Home.app, we just set TargetPosition to the corresponding max value, i.e. opening => 0; closing => 100 because we'll set the final target value anyways, once PositionState is STOPPED.

All other devices however, would be stuck with the current implementation.

Another relevant PR has been merged: Koenkk/zigbee-herdsman-converters#7470

@itavero Did you already had time to take a look at the PR?
I personally would have preferred to check for motor_state like you did with position and tilt, but unfortunately motor_state is not part of features...

Did you already had time to take a look at the PR?

Unfortunately I have not had time. Hopefully I can find a moment this week to do at least a quick check, but my schedule is still quite busy.

Unfortunately I have not had time. Hopefully I can find a moment this week to do at least a quick check, but my schedule is still quite busy.

Don't worry. 😊
Just let me know if I can help out somehow!

@itavero Would appreciate if you can already run the two workflows, so I can make any necessary changes in due time. ✌️

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 64.03%. Comparing base (31b0fd9) to head (b83009d).

❗ Current head b83009d differs from pull request most recent head 78d2848

Please upload reports for the commit 78d2848 to get more accurate results.

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
- Coverage   66.17%   64.03%   -2.14%     
==========================================
  Files          40       40              
  Lines        2903     2550     -353     
  Branches      792      619     -173     
==========================================
- Hits         1921     1633     -288     
- Misses        883      910      +27     
+ Partials       99        7      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itavero Alright, I've completely reworked how we're checking for the presence of motor_state, should now also work with multiple endpoints. 😅

Should probably also mention this in the changelog and the docs for the window covering, but I can also do that before merging the code.

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

🆗 Published SonarCloud and code coverage data.

@itavero Implemented the changes you've suggested. Based on my testing, everything still works! 😅