Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spectral-action doesn't fail on pull requests from forks #67

Open
bfabio opened this issue Jul 13, 2022 · 1 comment
Open

spectral-action doesn't fail on pull requests from forks #67

bfabio opened this issue Jul 13, 2022 · 1 comment
Labels
ci Continuous integration or build

Comments

@bfabio
Copy link
Member

bfabio commented Jul 13, 2022 •
edited

When a PR is opened from a fork, spectral-action doesn't fail if there are errors, but just adds annotation errors in the action logs.

This is tracked upstream as stoplightio/spectral-action#624
@LorenzoS92 LorenzoS92 modified the milestone: Technical Demo Jul 13, 2022
bfabio added a commit to bfabio/developers-italia-api that referenced this issue Jul 20, 2022
@bfabio
chore: add checks permissions to spectral action
fba6f10 
See italia#67.
@bfabio bfabio mentioned this issue Jul 20, 2022
Merged
bfabio added a commit that referenced this issue Jul 20, 2022
@bfabio
chore: add checks permissions to spectral action (#80)
1752029 
See #67.
@bfabio
Copy link
Member Author

bfabio commented Jul 21, 2022

Tried a workaround with #80, but it didn't work.

My guess is that, since the action uses annotations, it has to have checks write permissions in the repo context, which it doesn't and can't have when the repo is a fork.

The action could comment on the PR content instead, but in that case it wouldn't be able to properly work on the whole file, given that GitHub doesn't support commenting on unchanged lines in a pull request yet.

@bfabio bfabio added the ci Continuous integration or build label Nov 26, 2022
@willosborne willosborne mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Continuous integration or build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bfabio @LorenzoS92