Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to exclude files on coverage report generation #982

Merged
merged 1 commit into from Feb 20, 2019
Merged

Add support to exclude files on coverage report generation #982

merged 1 commit into from Feb 20, 2019

Conversation

henriquemotaesteves
Copy link
Contributor

Add support to exclude files on coverage report generation (istanbuljs/istanbuljs#275) to nyc (#956).

@coveralls
Copy link

coveralls commented Jan 31, 2019

Coverage Status

Coverage increased (+0.1%) to 96.524% when pulling 774d355 on henriquemotaesteves:issue-#956 into 12b8986 on istanbuljs:master.

@coreyfarrell
Copy link
Member

I'm not very familiar with the istanbul-api module, I've requested that @bcoe also review this. I'm a bit busy right now but hopefully I'll be able to look at this soon.

@JaKXz
Copy link
Member

JaKXz commented Feb 19, 2019

@henriquemotaesteves sorry about this, would you mind rebasing this PR?

Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. One question that comes to mind though, is what advantage to we get by pulling in istanbul-api ... I always felt like istanbul-api felt like a weird abstraction, what does it add over using istanbul-report directly, and adding the exclude logic to istanbul-report ... just wondering what the value is of the extra layer of indirection.

Not a blocker for me though, just a question -- did you find you liked the api better exposed through istanbul-api, vs., interacting with the report module directly?

@bcoe
Copy link
Member

bcoe commented Feb 19, 2019

@henriquemotaesteves looking good to me once you rebase and tests pass.

@JaKXz JaKXz merged commit 509c6aa into istanbuljs:master Feb 20, 2019
AndrewFinlay added a commit to AndrewFinlay/nyc that referenced this pull request Feb 21, 2019
feat: add support to exclude files on coverage report generation (istanbuljs#982)
coreyfarrell added a commit that referenced this pull request Feb 22, 2019
coreyfarrell added a commit to coreyfarrell/nyc that referenced this pull request Mar 6, 2019
coreyfarrell added a commit to coreyfarrell/nyc that referenced this pull request Mar 7, 2019
coreyfarrell added a commit that referenced this pull request Mar 7, 2019
@coreyfarrell coreyfarrell mentioned this pull request Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants