Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update language of ISSUE_TEMPLATE. #901

Merged
merged 1 commit into from Aug 27, 2018

Conversation

coreyfarrell
Copy link
Member

Ask for link to repository first, add text explaining the importance of
linking a repository that demonstrates the bug.

@coreyfarrell coreyfarrell requested review from JaKXz and bcoe August 9, 2018 15:45
Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. One possible improvement would be to be a bit more descriptive and encouraging about the minimal-ness of the reproduction required.

Another improvement would be to include steps on how someone might get up to speed with debugging nyc.

It would be really cool if there was a way to help people go from issues to PRs, but as you mentioned, NYC is extremely complex. In any case, I feel like even helping someone submit failing tests would be a huge win.

Anyway, these are just my general thoughts, I think this is good to :shipit: it's well written and firm without being aggressive :) great job.

ISSUE_TEMPLATE Outdated
even impossible to triage most bugs without this information.

If you cannot share a link to your repository (maybe it's private) then you must
create a basic `nyc-bug-demo` repository, link to that.
Copy link
Member

@JaKXz JaKXz Aug 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only nit here is the extra comma, I would rewrite it as:

... repository and link to that please.

Ask for link to repository first, add text explaining the importance of
linking a repository that demonstrates the bug.
@coreyfarrell coreyfarrell merged commit 3b95858 into istanbuljs:master Aug 27, 2018
@coreyfarrell coreyfarrell deleted the issue-template branch August 27, 2018 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants