Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is a Vulnerability in nyc 15.1.0 #1367

Closed
deleonio opened this issue Nov 19, 2020 · 8 comments
Closed

There is a Vulnerability in nyc 15.1.0 #1367

deleonio opened this issue Nov 19, 2020 · 8 comments

Comments

@deleonio
Copy link

Description

There is a vulnerability in y18n: https://snyk.io/test/npm/nyc/15.1.0

Solution

Try to update / upgrade yargs.

@KTOmega
Copy link

KTOmega commented Nov 19, 2020

+1, I have a project that's impacted by this vulnerability rooted in our dependency on nyc (and mocha).

An issue I see is that the latest yargs doesn't support Node v8, whereas nyc seems to, based on the package.json & the tests in the linked PR. Does the nyc team have a roadmap for deprecating support for Node v8?

@coreyfarrell
Copy link
Member

nyc 15 will never drop support for node.js 8, doing so is semver major (node.js 8 being EOL is not relevant to this). nyc 16 will require node.js 10 but it is not going to be rushed out (no current timeframe for nyc 16 to be released). The only way this issue can possibly be hit is if the system environment variable LC_ALL is set to __proto__ before nyc runs. This would only happen if your system is compromised to begin with.

yargs/y18n#112 is the upstream bug, if a fix is backported to y18n 4.x then yargs 15 and thus nyc 15 will be able to pull the fix per semver range.

Leaving this ticket open so others can see the status.

@bcoe
Copy link
Member

bcoe commented Nov 30, 2020

@coreyfarrell I have released y18n@4.0.1 which has the patch.

@coreyfarrell
Copy link
Member

@bcoe thanks for taking care of this!

Closing this ticket as an in-range update is now available.

@firefoxNX
Copy link

will there be a nyc release to update y18n to version 4.0.1?

@coreyfarrell
Copy link
Member

will there be a nyc release to update y18n to version 4.0.1?

No, nyc only gets a new release for dependency updates when an out of range update is required.

@firefoxNX
Copy link

Sorry I am new to nodejs. What do you mean by "out of range update"?

@coreyfarrell
Copy link
Member

Out of range versions would not be allowed by the dependency definitions. In this case y18n@^4.0.0 is pulled in by the version of yargs we require. The ^4.0.0 means that any version 4.x.x will be accepted (it's in range). If your project is still installing 4.0.0 then you need to run updates locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants