Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data merge concurrency #1293

Merged
merged 4 commits into from Apr 1, 2020
Merged

Data merge concurrency #1293

merged 4 commits into from Apr 1, 2020

Conversation

canonic-epicure
Copy link
Contributor

This PR fixes #1263

Instead of fetching all reports into memory and then merging, we do that one-by-one.

@canonic-epicure canonic-epicure mentioned this pull request Mar 23, 2020
Closed
coreyfarrell
coreyfarrell requested changes Mar 23, 2020
View reviewed changes
Copy link
Member

@coreyfarrell coreyfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems logical to me, I'd like to get some more feedback from reporters of the OOM issue to verify it actually fixes the issue before actually merging and releasing.

.gitignore Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
@medikoo medikoo mentioned this pull request Mar 29, 2020
Merged
@coreyfarrell coreyfarrell merged commit df34c1c into istanbuljs:master Apr 1, 2020
@dependabot dependabot bot mentioned this pull request Mar 12, 2021
Open
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreyfarrell coreyfarrell coreyfarrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaScript heap out of memory in v15.0.0.
2 participants
@canonic-epicure @coreyfarrell