feat: Add --use-spawn-wrap=true option

[coreyfarrell]

Completely bypass spawn-wrap unless overridden with this new option.

[coveralls]

Coverage increased (+0.008%) to 99.789% when pulling 350cfbd on coreyfarrell:set-node-options into 408c1cb on istanbuljs:master.

[coreyfarrell]

The branches following this line are version dependent. I have tested all three branches locally using node.js 8, 10 and 12. I've tested with nyc in a directory with and without spaces and double-quote.

[JaKXz]

Does the ENOMEM error still occur on Windows with node 10+? Could we try re-enabling it in travis for coverage? :)

[coreyfarrell]

It does still occur, specifically on 10.16.0 and above. Technically we could add 10.15.0 into testing.

See test log from yesterday when testing node-preload - https://travis-ci.org/cfware/node-preload/builds/582661358

[isaacs]

This is cool. When did the support for env.NODE_OPTIONS land?

[coreyfarrell]

This is cool. When did the support for env.NODE_OPTIONS land?

node.js 8.0.0 added the option: https://nodejs.org/dist/latest-v8.x/docs/api/cli.html#cli_node_options_options

node.js < 12 does not support quoting the path given to --require so it is not possible to directly do:

process.env.NODE_OPTIONS = `--require ${pathWithSpaces}`

[isaacs]

I was thinking about the case where someone clears the environment variable before calling spawn, like spawn(process.execPath, ['foo.js'], { env: { NODE_OPTIONS: 'different' } }).

We could update nyc's wrap.js to munge ChildProcess.spawn kind of like how spawn-wrap does, but without writing a shim file, such that it always puts the environment variable back in.

Then the only hazard would be something like spawn('bash', ['escape.sh']) where escape.sh does NODE_OPTIONS= node foo.js, but that's enough of an explicit step that we should probably respect it anyway.

[coreyfarrell]

I was thinking about the case where someone clears the environment variable before calling spawn, like spawn(process.execPath, ['foo.js'], { env: { NODE_OPTIONS: 'different' } }).

We could update nyc's wrap.js to munge ChildProcess.spawn kind of like how spawn-wrap does, but without writing a shim file, such that it always puts the environment variable back in.

I thought of this, I've created https://github.com/cfware/node-preload as a potential alternative to spawn-wrap. The functionality has enough platform/version edge cases that it probably deserves it's own testing. I'm actually looking to get it to a state where it might be possible to get the functionality into the node.js core. My module is not published to npm yet, I want to get a little feedback first.

Then the only hazard would be something like spawn('bash', ['escape.sh']) where escape.sh does NODE_OPTIONS= node foo.js, but that's enough of an explicit step that we should probably respect it anyway.

Agreed. Also we can't control everything.