docs: Point to updated location of default exclude list #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaKXz
reviewed
May 9, 2019
| @@ -100,7 +100,7 @@ This table is a quick TLDR for the rest of this readme and there are more advanc | |||
| | `check-coverage` | Check whether coverage is within thresholds, fail if not | `Boolean` | `false` | | |||
| | `extension` | List of extensions that nyc should attempt to handle in addition to `.js` | `Array<String>` | `['.js']` | | |||
| | `include` | See [selecting files for coverage] for more info | `Array<String>` | `['**']`| | |||
| | `exclude` | See [selecting files for coverage] for more info | `Array<String>` | [list](https://github.com/istanbuljs/istanbuljs/blob/master/packages/test-exclude/index.js#L176-L184) | | |||
| | `exclude` | See [selecting files for coverage] for more info | `Array<String>` | [list](https://github.com/istanbuljs/istanbuljs/blob/master/packages/test-exclude/default-exclude.js) | | |||
There was a problem hiding this comment.
This list is also mentioned (and already outdated) in the selecting files for coverage section. We should fix that, ideally with a github embed in the readme in that section rather than the static list...
There was a problem hiding this comment.
I can link the content but I'm not sure how to embed content in a README? I think that might be a special feature just for issue/PR comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.