Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slack badge image insecure content warning #1105

Merged
merged 1 commit into from May 8, 2019
Merged

Fix Slack badge image insecure content warning #1105

merged 1 commit into from May 8, 2019

Conversation

calvinf
Copy link
Contributor

@calvinf calvinf commented May 8, 2019

Image is no longer insecure when viewing REAMDE off of github (which does not serve the original image URLs). Previously, the insecure content warning would show on npm when viewing the nyc package.

Image is no longer insecure when viewing REAMDE off of github (which does not serve the original image URLs).
Copy link
Member

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JaKXz JaKXz merged commit 0cc7309 into istanbuljs:master May 8, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.87% when pulling 93ba05f on calvinf:patch-1 into 3cdfb8e on istanbuljs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.87% when pulling 93ba05f on calvinf:patch-1 into 3cdfb8e on istanbuljs:master.

@calvinf calvinf deleted the patch-1 branch May 8, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants