chore: node.js 12 compatibility for object snapshot test. #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node.js 12 changes the format of `util.inspect`, this causes snapshot mismatch. Replace our one object snapshot with a JSON stringified array of `[name, value]` pairs representing the object. Use an array sorted by names as JSON.stringify does not guaruntee order of elements in an object.
coreyfarrell
force-pushed
the
node12-fix-snapshot
branch
from
0d9ee76
to
51f0698
Compare
|
Apparently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node.js 12 changes the format of
util.inspect, this causes snapshotmismatch. We only use object snapshot testing in one place so call
util.inspectmanually withcompact: falseoption to force consistentoutput before / after node.js 12.
CC @isaacs not sure if tap@12 can/should do anything about this, kind of a tough situation as
compact: falsewould be a breaking change for tap. Either way figure you might want to know about this.