chore: Convert some tap tests to run parallel and use snapshots. #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create `npm run lint`, recreate `npm run report`.
isaacs
reviewed
Apr 19, 2019
|
@JaKXz @bcoe I've made a few tweaks, mainly moving some code from the test file to helpers. Partly this is due to the test @isaacs posted in #1077 made me realize that we might want to share more code. One internal behavior change instead of adding stdio chunks directly to a string I'm now using an array of buffers and Buffer.concat at the end. In theory this shouldn't have an effect but I just like the code better (saw it in #1077). |
isaacs
added a commit
to tapjs/tapjs
that referenced
this pull request
Apr 19, 2019
Prompted by discussion in istanbuljs/nyc#1075 (comment)
JaKXz
reviewed
Apr 21, 2019
isaacs
added a commit
to tapjs/tapjs
that referenced
this pull request
Apr 22, 2019
Prompted by discussion in istanbuljs/nyc#1075 (comment)
bcoe
approved these changes
Apr 22, 2019
* Split helpers into individual files, create index.js to export everything useful to tests. * Rename test files - nyc-integration-old.js for tests that have not been migrated, nyc-integration.js for tests which have been migrated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.