Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update issue template #1008

Merged
merged 4 commits into from Apr 15, 2019
Merged

docs: update issue template #1008

merged 4 commits into from Apr 15, 2019

Conversation

JaKXz
Copy link
Member

@JaKXz JaKXz commented Mar 1, 2019

When tabrindle/envinfo#90 + tabrindle/envinfo#93 is released (and fixed) this will be 馃敟

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.639% when pulling c26d774 on JaKXz-patch-1 into b64d921 on master.

@coreyfarrell
Copy link
Member

I think this is a great idea once the pattern matching like *istanbul* works correctly.

@JaKXz JaKXz added the pinned label Mar 28, 2019
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤thanks for this @JaKXz

.github/ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
@coreyfarrell
Copy link
Member

I just tried installing envinfo again, got the following output:

  System:
    OS: Linux 4.20 Fedora 28 (Twenty Eight) 28 (Twenty Eight)
    CPU: (8) x64 Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
    Memory: 5.95 GB / 31.26 GB
  Binaries:
    Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node
    Yarn: 1.13.0 - ~/.nvm/versions/node/v10.15.3/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.3/bin/npm
  npmPackages:
    *babel*: Not Found
    *istanbul*: Not Found
    nyc: ^13.3.0 => 13.3.0 
    source-map-support: Not Found
    ts-node: Not Found
    typescript: Not Found

If it can't find *istanbul* or *babel* then maybe we need to list some individual packages? In particular even if the glob based package matching worked I'm not sure it's a good idea to list all babel packages (usually 40+ babel packages). Maybe just @babel/core and @babel/register?

So I'm not sure this is ready. I do think we should list out the individual istanbul package versions, if envinfo does the glob or if another PR needs to be sent to envinfo to list out each important istanbul package.

@JaKXz
Copy link
Member Author

JaKXz commented Apr 10, 2019

@coreyfarrell we are waiting on a fix from @tabrindle [or a willing contributor 馃槃]. You are welcome to make a PR to envinfo to change the nyc preset but I think we should have all that information tbph, because e.g. some people might have babel 6 and that's a good red flag in the troubleshooting steps

@tabrindle
Copy link

Up to y'all on how you want to do this until I can add some more functionality to envinfo - here's one solution. tabrindle/envinfo#93

BTW, this is how vue-cli handles it for now.

@coreyfarrell
Copy link
Member

tabrindle/envinfo#93 is definitely a big improvement.

@JaKXz do you think we need to tell people to use envinfo --preset nyc --fullTree? Without fullTree this will not show any module that is not specified by the local package.json (istanbul-lib-instrument for example). This might not be a big deal for older versions of nyc that bundle everything but for nyc 14+ won't bundle so it'll be possible for istanbul-lib-instrument to be updated without a new nyc release.

@coreyfarrell
Copy link
Member

I just realized that the preset could specify options: {fullTree: true} and this would work. Do we want that?

Copy link
Member

@coreyfarrell coreyfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval applies once tabrindle/envinfo#93 is merged and released.

@JaKXz JaKXz merged commit 8cf8a89 into master Apr 15, 2019
@tabrindle
Copy link

Published in envinfo@7.2.0

npx envinfo@7.2.0 --preset nyc

@bcoe bcoe deleted the JaKXz-patch-1 branch April 15, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants