You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are noticing some odd things when trying to combine the coverage.
Looking at the JSON report for the statementMap
Both commonly have a null for the end column but in some instances karma will report a null and cypress (with istanbul instrumentation) will report a specific end column number. When these are combined via nyc they are treated as 2 different statements for the coverage stats { "start": { "line": 16, "column": 4 }, "end": { "line": 16, "column": null } }
vs { "start": { "line": 16, "column": 4 }, "end": { "line": 16, "column": 46 } }
What does a null column end mean? Could the merge handle this more gracefully?
In this case 16 was wrapped in a if statement that the cypress coverage picked up on for the statementMap and also the branchMap but the karma coverage omited from both. { "start": { "line": 15, "column": 2 }, "end": { "line": 17, "column": null } }
We also saw the same thing happen outside the if statement { "start": { "line": 18, "column": 2 }, "end": { "line": 18, "column": 14 } }
vs { "start": { "line": 18, "column": 2 }, "end": { "line": 18, "column": null } }
We are noticing some odd things when trying to combine the coverage.
Looking at the JSON report for the statementMap
Both commonly have a null for the end column but in some instances karma will report a null and cypress (with istanbul instrumentation) will report a specific end column number. When these are combined via nyc they are treated as 2 different statements for the coverage stats
{ "start": { "line": 16, "column": 4 }, "end": { "line": 16, "column": null } }
vs
{ "start": { "line": 16, "column": 4 }, "end": { "line": 16, "column": 46 } }
What does a null column end mean? Could the merge handle this more gracefully?
In this case 16 was wrapped in a if statement that the cypress coverage picked up on for the statementMap and also the branchMap but the karma coverage omited from both.
{ "start": { "line": 15, "column": 2 }, "end": { "line": 17, "column": null } }
We also saw the same thing happen outside the if statement
{ "start": { "line": 18, "column": 2 }, "end": { "line": 18, "column": 14 } }
vs
{ "start": { "line": 18, "column": 2 }, "end": { "line": 18, "column": null } }
And also the same null ending column issue in the fnMap
{ "name": "getError", "decl": { "start": { "line": 14, "column": 16 }, "end": { "line": 14, "column": 24 } }, "loc": { "start": { "line": 14, "column": 45 }, "end": { "line": 19, "column": null } } }
vs
{ "name": "getError", "decl": { "start": { "line": 14, "column": 16 }, "end": { "line": 14, "column": 24 } }, "loc": { "start": { "line": 14, "column": 45 }, "end": { "line": 19, "column": 1 } }
The text was updated successfully, but these errors were encountered: