New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore insignificant lines when coalesce #525
Conversation
Earned 11 extra chars for `MISSING_COL`
Earned 3 extra chars for `MISSING_COL`
Use 80 columns width by default, unlimited if `maxCols` option is set explicitly to zero
Any update on this? Can be reviewed and merged? :-) |
@piranna sorry for the delay, I've been a bit buried lately but I promise I will review this ASAP. |
No problem, take your time :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I reviewed each change to the tested text reports.
@SimenB @bcoe this changes the output of some text reports so it could break any snapshot testing you have on c8 and jest (maybe less likely for c8). I'll deal with fixing the snapshot tests for nyc but I just wanted to give warning and make sure you don't have strong objections. I'm viewing this as a non-breaking change, I don't think istanbul-reports has an obligation to maintain exact byte-for-byte output of the text report (humans are the target consumer, not computers).
Yeah go ahead! I think it's fair not to regard the visual output as covered by semver - we use a lockfile anyways, so CI won't randomly break for us whenever a release is out 👍 |
Thank you for reviewing them :-) |
This is published to @piranna very much appreciate your work on this, IMO the updated reports look MUCH better (you can see tap-snapshots changes in the nyc PR). |
Great! :-D
You are welcome :-) I use coverage reports a lot when running Jest tests and was missing to see more missing lines on it and what of them needed more priority (not the best way to do tests, but help to do regression tests). Thank you for accepting it upstream, hope this can be useful for that and to others :-) |
FYI to immediately use this with jest you should be able to explicitly install |
I can bump in jest |
The changes looks great, awesome job! 👍 @coreyfarrell any idea how long it'll be tagged as next? |
Unless I get an objection I'm probably going to promote it to latest tomorrow. I just posted a message to our Slack requesting that people test it on projects that do not have 100% coverage. |
Updates for both istanbul-reports and nyc are now promoted to |
Thanks! Merged the Jest PR with updated snapshots now. Not sure when a release will come which forces the update for consumers, but just deleting |
Fixes #514.