Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete (left) Is Not Repeating #1098

Open
ash34 opened this issue Apr 10, 2024 · 9 comments
Open

Delete (left) Is Not Repeating #1098

ash34 opened this issue Apr 10, 2024 · 9 comments
Assignees
Labels
🐛 bug Something isn't working
Milestone

Comments

@ash34
Copy link

ash34 commented Apr 10, 2024

Bug description

Using version 25.8.1329 on an iPad the delete key is not repeating.
Virtual cursor key repeats ok though.

Steps to reproduce

  1. Use cursor up to select a previous command
  2. Trying deleting some of it with the delete key (backspace key)
  3. Only deletes one character at a time

Actually I noticed the problem in the previous release also but thought I was the faulty component.

@isontheline
Copy link
Owner

Hello @ash34 👋

I think I'm the faulty component due to this issue : #642

Thanks for your report, I'll check and make a fix

@isontheline
Copy link
Owner

By using the virtual keyboard?

@ash34
Copy link
Author

ash34 commented Apr 10, 2024

Yes, not a physical keyboard. I don’t have one to test with.

@isontheline
Copy link
Owner

OK so you are referring to the custom {DEL} Delete Key?

@ash34
Copy link
Author

ash34 commented Apr 10, 2024 via email

@isontheline
Copy link
Owner

Seems to work as expected on my own :
backspace

But perhaps a trouble may occur in some circumstances

@isontheline isontheline self-assigned this Apr 10, 2024
@isontheline isontheline added the 🐛 bug Something isn't working label Apr 10, 2024
@ash34
Copy link
Author

ash34 commented Apr 10, 2024

I have now update the steps to reproduce.

@isontheline
Copy link
Owner

@ash34 Perfect 🙏

@isontheline isontheline added this to the 26 - Train milestone Apr 10, 2024
@isontheline
Copy link
Owner

Issue #642 prevents the backspace key to be repeated when the text buffer is empty.

Text buffer is empty when we use previous history for example. Empty because WebSSH doesn't know what to put in the buffer.

I'm searching a solution to resolve #642 and backspace repeat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants