Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade from 2.9.0 to 2.10.0 leads to invalid_redirect_uri error #48

Closed
srt32 opened this issue Aug 18, 2017 · 8 comments
Closed

upgrade from 2.9.0 to 2.10.0 leads to invalid_redirect_uri error #48

srt32 opened this issue Aug 18, 2017 · 8 comments

Comments

@srt32
Copy link

srt32 commented Aug 18, 2017

We recently upgraded from 2.9.0 to 2.10.0. Upon upgrading we experienced the below invalid_redirect_uri error that we did not see before the upgrade.

This version bump seems to only bump transitive dependencies. Is there any updated config needed to make the new version work properly?

{
  "error": "invalid_redirect_uri",
  "error_description": "Invalid redirect URI 'https://mydomain.com/callback'. Ensure this uri exactly matches one of the uris specified in your application settings",
  "state": "state-field-foo"
}

Thanks!

@ryanclark2
Copy link
Contributor

We did some research and found that overriding the callback_url url in our strategy in our initializer and excluding the query_string made this work. It would be nice not to have to do that.

Related issue: omniauth/omniauth-oauth2#93 (comment)

🌞

@isaacsanders
Copy link
Owner

@srt32 @ryanclark2 @chrt00 PR #47 has the relevant method, but it is buried under adding the use of a JWT to the gem.

I would be happy to merge a PR with just the callback_url method defined.

@ryanclark2
Copy link
Contributor

@isaacsanders Yup, that's exactly what we did. If you'd like a PR with just that in it, let me know.

@isaacsanders
Copy link
Owner

I'm into it.

@isaacsanders
Copy link
Owner

As in, yes, I would like a PR, and will merge it in/cut a release.

@ryanclark2
Copy link
Contributor

Ha, I caught your drift. I'll send it over it a short bit. Thanks.

@isaacsanders
Copy link
Owner

Version 2.10.1 released

@isaacsanders
Copy link
Owner

@srt32 @ryanclark2 If either of you two are still working on this, I would appreciate it if you would confirm that 2.10.1 fixes the issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants