Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: migrate yallist to js-sdsl #401

Open
ZLY201 opened this issue Feb 21, 2024 · 1 comment
Open

Enhancement: migrate yallist to js-sdsl #401

ZLY201 opened this issue Feb 21, 2024 · 1 comment

Comments

@ZLY201
Copy link

ZLY201 commented Feb 21, 2024

@isaacs

Hey! I'm the developer of Js-sdsl. Official website: https://js-sdsl.github.io/

Now, we are going to published the version 5.0.0 (currently 5.0.0-beta.0).

I see you are using yallist.

In benchmark, we have confirmed that Js-sdsl is several times faster than yallist.

I've submitted a PR to eslint and has been accepted.

See eslint/eslint#16255 and eslint/eslint#16267.

I am willing to submit a pull request for this change.

Looking forward to your reply! :D

@isaacs
Copy link
Owner

isaacs commented Feb 21, 2024

This module is pending a rewrite in TS, but at that time, I'm almost certainly going to replace yallist with just using normal arrays, like I did with minipass. Most of the perf hits that I found using normal arrays were addressed in V8 quite a few years ago, around the node 8.x time frame iirc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants