Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate all versions prior to 4.x #58

Closed
ChALkeR opened this issue Feb 14, 2016 · 5 comments
Closed

Deprecate all versions prior to 4.x #58

ChALkeR opened this issue Feb 14, 2016 · 5 comments

Comments

@ChALkeR
Copy link
Contributor

ChALkeR commented Feb 14, 2016

Users should be warned that their setups will we soon broken with new Node.js releases.

This means to push a patch release to 1.x, 2.x, and 3.x branches.
Something similar to what lodash does:

npm WARN deprecated lodash@2.4.2: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^4.0.0.
npm WARN deprecated lodash@1.0.2: lodash@<3.0.0 is no longer maintained. Upgrade to lodash@^4.0.0.

Tracking issue: nodejs/node#5213

@ChALkeR
Copy link
Contributor Author

ChALkeR commented Feb 14, 2016

Proposed solution:
add

  "deprecated": "graceful-fs@<4.0.0 is deprecated and will be broken on newer Node.js versions. Upgrade to graceful-fs@^4.0.0 or later.",

to package.json of v2.1.0 and v3.0.8 and publish those as v2.1.1 and v3.0.9.

/cc @isaacs

@isaacs
Copy link
Owner

isaacs commented Feb 15, 2016

Thanks for the suggestion. I'll do this when I get to a computer.

Just so you know, and for posterity, editing package.json and publishing a new version is not the best way to deprecate a package. Deprecation should be done using the npm deprecate command.

@ChALkeR
Copy link
Contributor Author

ChALkeR commented Feb 15, 2016

@isaacs Ah, I wasn't aware that it is possible to that way, thanks!

@isaacs
Copy link
Owner

isaacs commented Feb 15, 2016

Done.

npm deprecate "graceful-fs@<4.0.0" "graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible."

@isaacs isaacs closed this as completed Feb 15, 2016
@ChALkeR
Copy link
Contributor Author

ChALkeR commented Feb 16, 2016

Thanks! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants