{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":63925755,"defaultBranch":"master","name":"cockroach","ownerLogin":"irfansharif","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2016-07-22T05:22:59.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/10536690?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1696887978.0","currentOid":""},"activityList":{"items":[{"before":"1e716fd50ef45a3d8a8055adf6904329bd5df743","after":"ca1a6d6e34a44d394db90270d78ddb055f713269","ref":"refs/heads/230921.ac-follower-overload","pushedAt":"2023-10-25T18:31:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aadityasondhi","name":"Aaditya Sondhi","path":"/aadityasondhi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20070511?s=80&v=4"},"commit":{"message":"roachtest: add admission-overload/follower-overload\n\nThis is just resuscitating #81516, tests we added when developing\nfollower pausing but never checked in. Some of this work is applicable\nin the context of replication admission control, when we apply flow\ncontrol for regular writes. The tests add an IO nemesis on n3/s3,\nrestricting disk bandwidth to 20MiB/s. They then observe what happens\nwhen remote nodes n1 and n2 issue follower write traffic to it, either\nacross many ranges or just 1 (potentially triggering the per-replica\nproposal quota pool). We can observe LSM state on n3/s3 under such\nconditions, and also what would happen if the concentrated follower node\nalso serves some foreground load.\n\nPart of #89208.\n\nRelease note: None","shortMessageHtmlLink":"roachtest: add admission-overload/follower-overload"}},{"before":"baacc6686d5c71dbbb1ed4d7322f35523b31be1f","after":"1e716fd50ef45a3d8a8055adf6904329bd5df743","ref":"refs/heads/230921.ac-follower-overload","pushedAt":"2023-10-25T18:14:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aadityasondhi","name":"Aaditya Sondhi","path":"/aadityasondhi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20070511?s=80&v=4"}},{"before":"7e01e054bc74e7289da7b62d01a3030908f9dc68","after":"baacc6686d5c71dbbb1ed4d7322f35523b31be1f","ref":"refs/heads/230921.ac-follower-overload","pushedAt":"2023-10-25T17:10:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aadityasondhi","name":"Aaditya Sondhi","path":"/aadityasondhi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20070511?s=80&v=4"}},{"before":"937348daa70cc86e6fa8fda07972eda034396d7f","after":"7e01e054bc74e7289da7b62d01a3030908f9dc68","ref":"refs/heads/230921.ac-follower-overload","pushedAt":"2023-10-25T14:40:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aadityasondhi","name":"Aaditya Sondhi","path":"/aadityasondhi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20070511?s=80&v=4"},"commit":{"message":"roachtest: add admission-overload/follower-overload\n\nThis is just resuscitating #81516, tests we added when developing\nfollower pausing but never checked in. Some of this work is applicable\nin the context of replication admission control, when we apply flow\ncontrol for regular writes. The tests add an IO nemesis on n3/s3,\nrestricting disk bandwidth to 20MiB/s. They then observe what happens\nwhen remote nodes n1 and n2 issue follower write traffic to it, either\nacross many ranges or just 1 (potentially triggering the per-replica\nproposal quota pool). We can observe LSM state on n3/s3 under such\nconditions, and also what would happen if the concentrated follower node\nalso serves some foreground load.\n\nPart of #89208.\n\nRelease note: None","shortMessageHtmlLink":"roachtest: add admission-overload/follower-overload"}},{"before":"3d6a6e4697bc2eaff2cbb3e9f6a853878b2c8695","after":"937348daa70cc86e6fa8fda07972eda034396d7f","ref":"refs/heads/230921.ac-follower-overload","pushedAt":"2023-10-25T14:28:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aadityasondhi","name":"Aaditya Sondhi","path":"/aadityasondhi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20070511?s=80&v=4"}},{"before":"3673c086ffabb520a2ae5cf0d80d6979c07885f8","after":"3d6a6e4697bc2eaff2cbb3e9f6a853878b2c8695","ref":"refs/heads/230921.ac-follower-overload","pushedAt":"2023-10-25T14:26:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aadityasondhi","name":"Aaditya Sondhi","path":"/aadityasondhi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20070511?s=80&v=4"},"commit":{"message":"roachtest: add admission-overload/follower-overload\n\nThis is just resuscitating #81516, tests we added when developing\nfollower pausing but never checked in. Some of this work is applicable\nin the context of replication admission control, when we apply flow\ncontrol for regular writes. The tests add add an IO nemesis on n3/s3,\nrestricting disk bandwidth to 20MiB/s. They then observe what happens\nwhen remote nodes n1 and n2 issue follower write traffic to it, either\nacross many ranges or just 1 (potentially triggering the per-replica\nproposal quota pool). We can observe LSM state on n3/s3 under such\nconditions, and also what would happen if the concentrated follower node\nalso what happens if that very node also serves some foreground load.\n\nPart of #89208.\n\nRelease note: None","shortMessageHtmlLink":"roachtest: add admission-overload/follower-overload"}},{"before":"18e66411fabc2de7392d2d6757308bdf4328e85c","after":"6de91e3b5769064a576bebfc0297aa8ec576e1a1","ref":"refs/heads/master","pushedAt":"2023-10-09T22:10:33.000Z","pushType":"push","commitsCount":7345,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"Merge #107589 #111905\n\n107589: sql: improve query plan for find-running-job-of-type query r=mgartner a=mgartner\n\nThis commit improves the query plan for the `find-running-jobs-of-type`\r\nquery by adding a hint to use the `jobs_status_created_idx` and by\r\nremoving an `ORDER BY` clause if a job ID to ignore was not given. This\r\ncan eliminate an index join from the query plan in some cases, making\r\nthe query plan more efficient.\r\n\r\nInforms #107405\r\n\r\nRelease note: None\r\n\n\n111905: streamingccl: physical replication stream from given timestamp r=adityamaru a=stevendanna\n\nThis adds a RESUME TIMESTAMP option to CREATE VIRTUAL CLUSTER FROM\r\nREPLICATION. When provided, we allow the user to start a replication\r\nstream into an _existing_ virtual cluster.\r\n\r\nWhen the resume timestamp is provided, the replication stream will be\r\nstarted from that timestamp, with no initial scan. To facilitate this,\r\nwe add a new argument to crdb_internal.start_replication_stream that\r\nallows us to pass a destination-choosen start timestamp.\r\n\r\nTo avoid various catastrophic mistakes, we only allow this when:\r\n\r\n- The destination tenant must be in service mode None\r\n\r\n- The provided resume timestamp equals the last recorded \"revert\r\n timestamp\" of the destination tenant. The revert timestamp is set when\r\n the tenant has been forcibly reverted to a particular timestamp and is\r\n cleared when the tenant is modified in a way that may invalidate a\r\n resumption from that timestamp.\r\n\r\n- If the source tenant has a PreviousSourceTenant set, the new\r\n destination must match that previous source tenant field.\r\n\r\nWARNING: Using this correctly requires that the stream is resumed\r\nbefore garbage collection has progressed past the given resume\r\ntimestamp. During normal operation, the replication stream maintains a\r\nprotected timestamp to ensure this is the case. However, when\r\nresuming using this new feature, we have no such guarantee.\r\n\r\nEpic: none\r\n\r\nRelease note: None\n\nCo-authored-by: Marcus Gartner \nCo-authored-by: Steven Danna ","shortMessageHtmlLink":"Merge cockroachdb#107589 cockroachdb#111905"}},{"before":"ed03b0c8249ab9464c13ffccc97e2afc9519218b","after":null,"ref":"refs/heads/230905.l0-ctrl-settings","pushedAt":"2023-10-09T21:46:18.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"474d11dfd2bcb48450506e3e74afe7f80e651e71","after":"3673c086ffabb520a2ae5cf0d80d6979c07885f8","ref":"refs/heads/230921.ac-follower-overload","pushedAt":"2023-09-21T17:58:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"roachtest: add admission-overload/follower-overload\n\nThis is just resuscitating #81516, tests we added when developing\nfollower pausing but never checked in. Some of this work is applicable\nin the context of replication admission control, when we apply flow\ncontrol for regular writes. The tests add add an IO nemesis on n3/s3,\nrestricting disk bandwidth to 20MiB/s. They then observe what happens\nwhen remote nodes n1 and n2 issue follower write traffic to it, either\nacross many ranges or just 1 (potentially triggering the per-replica\nproposal quota pool). We can observe LSM state on n3/s3 under such\nconditions, and also what would happen if the concentrated follower node\nalso what happens if that very node also serves some foreground load.\n\nPart of #89208.\n\nRelease note: None","shortMessageHtmlLink":"roachtest: add admission-overload/follower-overload"}},{"before":null,"after":"474d11dfd2bcb48450506e3e74afe7f80e651e71","ref":"refs/heads/230921.ac-follower-overload","pushedAt":"2023-09-21T17:58:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"d2184f9a4e338b42472e5d28ad3e3e0b6afb747f","after":null,"ref":"refs/heads/230905.flowcontrol-ui","pushedAt":"2023-09-21T17:27:40.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"a1690a20c450d8b0ffc3c28b1a94f66430214831","after":"17c622086c8b30fd34baaf4799606947e17b802c","ref":"refs/heads/230921.ac-pk-change","pushedAt":"2023-09-21T17:21:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"roachtest,admission: scale-test for large PK changes\n\nThis should also benefit from replication admission control.\n\nRelease note: None","shortMessageHtmlLink":"roachtest,admission: scale-test for large PK changes"}},{"before":"a389641d64b21908a7a137030556c0918e2768f7","after":"a1690a20c450d8b0ffc3c28b1a94f66430214831","ref":"refs/heads/230921.ac-pk-change","pushedAt":"2023-09-21T16:53:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":null,"after":"a389641d64b21908a7a137030556c0918e2768f7","ref":"refs/heads/230921.ac-pk-change","pushedAt":"2023-09-21T15:14:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"425d59b9c515235dfc0cb58662e8312ed04055c9","after":"d2184f9a4e338b42472e5d28ad3e3e0b6afb747f","ref":"refs/heads/230905.flowcontrol-ui","pushedAt":"2023-09-21T14:46:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"ui: surface flow control metrics in overload dashboard\n\nSome of this new flow control machinery changes the game for IO\nadmission control. This commits surfaces relevant metrics to the\noverload dashboard:\n- kvadmission.flow_controller.{regular,elastic}_wait_duration-p75\n- kvadmission.flow_controller.{regular,elastic}_requests_waiting\n- kvadmission.flow_controller.{regular,elastic}_blocked_stream_count\n\nWhile here, we replace the storage.l0-{sublevels,num-files} metrics with\nthe admission.io.overload instead. The former showed the raw counts\ninstead of normalizing it based on AC target thresholds. And the y-axis\nscales for sublevels vs. files are an order of magnitude apart, so\nslightly more annoying to distinguish.\n\nRelease note: None","shortMessageHtmlLink":"ui: surface flow control metrics in overload dashboard"}},{"before":"cee842ea6c16ba3e2c44378c3a67b6b3fc6ca5c8","after":"425d59b9c515235dfc0cb58662e8312ed04055c9","ref":"refs/heads/230905.flowcontrol-ui","pushedAt":"2023-09-21T14:24:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"ui: surface flow control metrics in overload dashboard\n\nSome of this new flow control machinery changes the game for IO\nadmission control. This commits surfaces relevant metrics to the\noverload dashboard:\n- kvadmission.flow_controller.{regular,elastic}_wait_duration-p75\n- kvadmission.flow_controller.{regular,elastic}_requests_waiting\n- kvadmission.flow_controller.{regular,elastic}_blocked_stream_count\n\nWhile here, we replace the storage.l0-{sublevels,num-files} metrics with\nthe admission.io.overload instead. The former showed the raw counts\ninstead of normalizing it based on AC target thresholds. And the y-axis\nscales for sublevels vs. files are an order of magnitude apart, so\nslightly more annoying to distinguish.\n\nRelease note: None","shortMessageHtmlLink":"ui: surface flow control metrics in overload dashboard"}},{"before":"35d119f02b5e2d39dfcaa4133007a607bb1a3254","after":null,"ref":"refs/heads/230920.technote-url","pushedAt":"2023-09-21T02:56:38.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"472deb29bd2f7a78b9098cb512dea38733a07250","after":"cee842ea6c16ba3e2c44378c3a67b6b3fc6ca5c8","ref":"refs/heads/230905.flowcontrol-ui","pushedAt":"2023-09-21T01:08:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"ui: surface flow control metrics in overload dashboard\n\nSome of this new flow control machinery changes the game for IO\nadmission control. This commits surfaces relevant metrics to the\noverload dashboard:\n- kvadmission.flow_controller.{regular,elastic}_wait_duration-p75\n- kvadmission.flow_controller.{regular,elastic}_requests_waiting\n- kvadmission.flow_controller.{regular,elastic}_blocked_stream_count\n\nWhile here, we replace the storage.l0-{sublevels,num-files} metrics with\nthe admission.io.overload instead. The former showed the raw counts\ninstead of normalizing it based on AC target thresholds. And the y-axis\nscales for sublevels vs. files are an order of magnitude apart, so\nslightly more annoying to distinguish.\n\nRelease note: None","shortMessageHtmlLink":"ui: surface flow control metrics in overload dashboard"}},{"before":null,"after":"35d119f02b5e2d39dfcaa4133007a607bb1a3254","ref":"refs/heads/230920.technote-url","pushedAt":"2023-09-21T00:50:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"docs: update url links\n\nThese don't auto-expand inline unless pointing to the same repo they're\nin.\n\nRelease note: None","shortMessageHtmlLink":"docs: update url links"}},{"before":null,"after":"c84ea7e6d21d9ecdb1cdd10a899107e266a483ad","ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-21T00:43:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"docs: add tech note for replication admission control\n\nRelease note: None","shortMessageHtmlLink":"docs: add tech note for replication admission control"}},{"before":"c84ea7e6d21d9ecdb1cdd10a899107e266a483ad","after":null,"ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-21T00:36:42.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"d3752afd3cdc5eb0ae5d89ca5baf61bc4b6a58e3","after":"c84ea7e6d21d9ecdb1cdd10a899107e266a483ad","ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-20T23:36:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"docs: add tech note for replication admission control\n\nRelease note: None","shortMessageHtmlLink":"docs: add tech note for replication admission control"}},{"before":"4da2627b9ee8bc57d4a5d0f40dad8486a23507c4","after":null,"ref":"refs/heads/230905.ac-histogram","pushedAt":"2023-09-19T21:03:18.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"352c51edaf985d07f0e53fcea6e1b98ea89d9149","after":"d3752afd3cdc5eb0ae5d89ca5baf61bc4b6a58e3","ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-19T03:41:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"docs: add tech note for replication admission control\n\nRelease note: None","shortMessageHtmlLink":"docs: add tech note for replication admission control"}},{"before":"0b186c1e9a273c292a9cdeb8be42b6bf8e261229","after":"352c51edaf985d07f0e53fcea6e1b98ea89d9149","ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-19T03:40:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"8eded1b3818bd7cb2acc294a50c07411d7da3583","after":"0b186c1e9a273c292a9cdeb8be42b6bf8e261229","ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-19T03:25:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"cea05406784a61102d750da4d6fe3ee3b4d02276","after":"8eded1b3818bd7cb2acc294a50c07411d7da3583","ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-18T22:37:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"5c7591b4bfca090709d88c155e86076281815963","after":"cea05406784a61102d750da4d6fe3ee3b4d02276","ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-18T22:23:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}},{"before":"a388ec5f0094166c943c8f3bb2f14b358c4dc771","after":"5c7591b4bfca090709d88c155e86076281815963","ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-18T20:30:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"},"commit":{"message":"docs: add tech note for replication admission control\n\nRelease note: None","shortMessageHtmlLink":"docs: add tech note for replication admission control"}},{"before":"e57477bbc157d6ca9b046dc758dc9c425312465f","after":"a388ec5f0094166c943c8f3bb2f14b358c4dc771","ref":"refs/heads/230918.kvflowcontrol-tech-note","pushedAt":"2023-09-18T16:03:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"irfansharif","name":"irfan sharif","path":"/irfansharif","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10536690?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADn8J2VgA","startCursor":null,"endCursor":null}},"title":"Activity ยท irfansharif/cockroach"}