Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split tmkms into multiple, more modular crates. #684

Open
ewoolsey opened this issue Dec 21, 2022 · 2 comments
Open

split tmkms into multiple, more modular crates. #684

ewoolsey opened this issue Dec 21, 2022 · 2 comments

Comments

@ewoolsey
Copy link

tmkms has a lot of potentially useful logic baked into it. For my particular use case it would be fantastic to have access to just the cosmos ledger signing logic. I could see this being much more modular and useful to other projects if it were split into 2 or even 3 different crates!

@tony-iqlusion
Copy link
Member

We're working on a next-generation KMS with a multi-crate architecture here:

https://github.com/iqlusioninc/iqkms

That said, we are not going to make major architectural changes to TMKMS. It's mission-critical and stable in its current form.

I'm curious to know what parts of the transaction signing logic are still valuable. They all predate the migration to Protobufs. I understand how the Amino JSON parts are still valuable specifically in the context of Ledger signing, but do you still need Amino binary serialization support? It carries a high maintenance burden.

I would suggest factoring whatever parts you find are still valuable for e.g. Ledger signing into CosmRS:

https://github.com/cosmos/cosmos-rust

@ewoolsey
Copy link
Author

I didn't know about iqkms actually so that answers my question there. I must have missed that somehow. I'll have to look into that.

but do you still need Amino binary serialization support?

To be honest at this point I'm not entirely certain what my requirement are. I'm still yet to have success with getting a ledger signature to be properly validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants