From dc2ba6afce2bab6f35f7e8c167d7cf3ef69bda3c Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Thu, 15 Dec 2022 11:05:02 -0600 Subject: [PATCH 1/3] fix lint --- .pre-commit-config.yaml | 2 +- pyproject.toml | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index ff708b29..db437d81 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -34,7 +34,7 @@ repos: - id: black - repo: https://github.com/charliermarsh/ruff-pre-commit - rev: v0.0.165 + rev: v0.0.178 hooks: - id: ruff args: ["--fix"] diff --git a/pyproject.toml b/pyproject.toml index 6afe1e49..6ed55299 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -28,7 +28,7 @@ docs = [ "pydata-sphinx-theme", "sphinx" ] -lint = ["black>=22.6.0", "mdformat>0.7", "ruff>=0.0.156"] + typing = ["mypy>=0.990"] [tool.hatch.version] @@ -59,7 +59,8 @@ dependencies = ["mypy>=0.990"] test = "mypy --install-types --non-interactive {args:.}" [tool.hatch.envs.lint] -features = ["lint"] +dependencies = ["black==22.10.0", "mdformat>0.7", "ruff==0.0.178"] +detached = true [tool.hatch.envs.lint.scripts] style = [ "ruff {args:.}", @@ -161,7 +162,7 @@ ignore = [ # Line too long "E501", # Relative imports are banned - "I252", + "TID252", # Boolean ... in function definition "FBT001", "FBT002", # Module level import not at top of file From 0a61f2749bb2c6837e8508d39f876c8c5e5d5a5c Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Thu, 15 Dec 2022 11:05:50 -0600 Subject: [PATCH 2/3] fix typing --- pyproject.toml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 6ed55299..b429a9f9 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -29,8 +29,6 @@ docs = [ "sphinx" ] -typing = ["mypy>=0.990"] - [tool.hatch.version] path = "traitlets/_version.py" @@ -53,7 +51,7 @@ test = "python -m pytest -vv --cov traitlets --cov-branch --cov-report term-miss nowarn = "test -W default {args}" [tool.hatch.envs.typing] -features = ["test", "typing"] +features = ["test"] dependencies = ["mypy>=0.990"] [tool.hatch.envs.typing.scripts] test = "mypy --install-types --non-interactive {args:.}" From e2debe4e7aea33df9d125a24f6a85d00eca55b0e Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 15 Dec 2022 17:06:08 +0000 Subject: [PATCH 3/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- traitlets/config/configurable.py | 1 - traitlets/config/loader.py | 1 - traitlets/tests/test_traitlets_enum.py | 1 - traitlets/utils/getargspec.py | 1 - 4 files changed, 4 deletions(-) diff --git a/traitlets/config/configurable.py b/traitlets/config/configurable.py index 919103f8..5f23df9e 100644 --- a/traitlets/config/configurable.py +++ b/traitlets/config/configurable.py @@ -24,7 +24,6 @@ from .loader import Config, DeferredConfig, LazyConfigValue, _is_section_key - # ----------------------------------------------------------------------------- # Helper classes for Configurables # ----------------------------------------------------------------------------- diff --git a/traitlets/config/loader.py b/traitlets/config/loader.py index 414912b7..0142c030 100644 --- a/traitlets/config/loader.py +++ b/traitlets/config/loader.py @@ -16,7 +16,6 @@ from ..utils import cast_unicode, filefind - # ----------------------------------------------------------------------------- # Exceptions # ----------------------------------------------------------------------------- diff --git a/traitlets/tests/test_traitlets_enum.py b/traitlets/tests/test_traitlets_enum.py index 52b7914e..c39007e8 100644 --- a/traitlets/tests/test_traitlets_enum.py +++ b/traitlets/tests/test_traitlets_enum.py @@ -8,7 +8,6 @@ from traitlets import CaselessStrEnum, Enum, FuzzyEnum, HasTraits, TraitError, UseEnum - # ----------------------------------------------------------------------------- # TEST SUPPORT: # ----------------------------------------------------------------------------- diff --git a/traitlets/utils/getargspec.py b/traitlets/utils/getargspec.py index 7fe8d2cc..e2b1f235 100644 --- a/traitlets/utils/getargspec.py +++ b/traitlets/utils/getargspec.py @@ -11,7 +11,6 @@ import inspect from functools import partial - # Unmodified from sphinx below this line