Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving tests out-of-tree? #14058

Open
bollwyvl opened this issue Apr 28, 2023 · 1 comment · May be fixed by #14059
Open

Moving tests out-of-tree? #14058

bollwyvl opened this issue Apr 28, 2023 · 1 comment · May be fixed by #14059

Comments

@bollwyvl
Copy link
Contributor

Currently, running the test suite relies on a large number of concrete path --ignore lines, which appears to fail during discovery, even if pyproject.toml is brought along... likely due to some path issues.

Proposed

Move all tests to a top-level tests folder, keeping basically the same structure. Include this in the .tar.gz, but exclude from .whl.

Pro:

Con:

  • the tests would no longer be part of the public API...
    • IPython.testing certainly can't move (but .testing.tests could)
    • but Hyrum's Law pretty much demands that it has been in use downstream
  • tests would be "further" from the things they test

Alternatives

Update the expected test procedure to use --pyargs IPython, and figure out how to ignore the discovery blockers here.

Pro:

  • no change to the API

Con:

  • keeps all the tests in the .whl
@bollwyvl bollwyvl linked a pull request Apr 28, 2023 that will close this issue
@bollwyvl
Copy link
Contributor Author

#14059 is up, showing what this would be like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant