Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the usage of minor-version entrypoints #13880

Merged

Conversation

UltimateLobster
Copy link
Contributor

Unfortunatly, as discussed here: #13815. The feature is not implemented correctly as the global wheel has the entrypoints hard-coded to the minor version of the python used to create them. This PR will remove that third entrypoint.

Side note: I didn't see any github acftion to publish new versions of the package. Will it be ok if I create a new PR with one and if so, would it be acceptible if I make it so the github action would run on all supported minor versions of python to create a wheel that is aware of the minor version (so the feature would be able to be re-implemented)?

@Carreau
Copy link
Member

Carreau commented Jan 3, 2023

I didn't see any github acftion to publish new versions of the package

No there is none,

I publish locally by signing the release commit with my local GPG key, and build the wheel twice to ensure that it's identical both time. The publish process also has a few step to push the wheel to a couple other archives.

See https://github.com/ipython/ipython/blob/6a4bff46d5bdcb231ed89cef1387cb7f2cccb271/tools/release_helper.sh

I'm happy to see improvements in the release process, but there are some of those steps i'm unsure how to integrate with GH action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants