Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable webagg in %matplotlib magic #13778

Merged
merged 4 commits into from Oct 29, 2022
Merged

Enable webagg in %matplotlib magic #13778

merged 4 commits into from Oct 29, 2022

Conversation

zhizheng1
Copy link
Contributor

@zhizheng1 zhizheng1 commented Oct 8, 2022

This PR enables %matplotlib webagg magic in IPython console. After these two simple changes webagg will be supported.

Fixes #13777

@zhizheng1
Copy link
Contributor Author

Could someone please take a look at this PR? It's quite straightforward.

@Carreau
Copy link
Member

Carreau commented Oct 19, 2022

Could someone please take a look at this PR? It's quite straightforward.

Thanks for your patience, some is usually me, and the last 3/4 weeks have been a bit complicated.

@Carreau
Copy link
Member

Carreau commented Oct 19, 2022

I've approved the test suite, and will mereg once it passes.

@zhizheng1
Copy link
Contributor Author

I accidentally updated the branch by merging the main into it; could you approve the test again.. I noticed some formatting failures in the previous run. Would it matter?

@zhizheng1
Copy link
Contributor Author

Did a cosmetic fix for formatting checks. Could someone please take a look or approve the tests?

@Carreau Carreau modified the milestones: High Interest, 8.6 Oct 29, 2022
@Carreau Carreau merged commit 1b5674c into ipython:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable webagg in %matplotlib magic
2 participants