Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced string path in _dh with PosixPath() #13669

Merged
merged 1 commit into from Aug 30, 2022

Conversation

achhina
Copy link
Contributor

@achhina achhina commented May 4, 2022

  • Read through Contribution doc
  • Ran tests locally

Here is a fix for GH-12967 (thanks @GalBr for pinpointing the issue), and is related to GH-12515.

Before:

python -m IPython
Python 3.10.0 (default, Nov 10 2021, 11:24:47) [Clang 12.0.0 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.4.0.dev -- An enhanced Interactive Python. Type '?' for help.

In [1]: cd ~
/Users/me

In [2]: _dh
Out[2]: [PosixPath('/Users/me/some/path'), '/Users/me']

Now:

python -m IPython                                     
Python 3.10.0 (default, Nov 10 2021, 11:24:47) [Clang 12.0.0 ]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.4.0.dev -- An enhanced Interactive Python. Type '?' for help.

In [1]: cd ~
/Users/me

In [2]: _dh
Out[2]: [PosixPath('/Users/me/some/path'), PosixPath('/Users/me')]

First time contributing here, read through the contribution doc but sorry if there's something I missed!

@Carreau Carreau added this to the 8.5 milestone Aug 30, 2022
@Carreau
Copy link
Member

Carreau commented Aug 30, 2022

First time contributing here, read through the contribution doc but sorry if there's something I missed!

Thanks, apologies for the super late reply. This seem perfect, it's small enough that there is likely no test needed.

Thanks.

@Carreau Carreau merged commit c2c6349 into ipython:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants