New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix uncaught BdbQuit
exceptions on ipdb exit
#13668
Conversation
I also tested to make sure that the change in this PR is compatible with the work done in #9942 and #9950 to enable running python -m IPython.terminal.debugger testDebug.py and it seems to be compatible. However, there were other strange problems relating to imports that did keep the |
- `BdbQuit` is now handled in the top-most scope of `InteractiveShell.run_code`. This ensures that `BdbQuit` is correctly handled but can still do its job of breaking out of all user code/loops/further breakpoint requests. Hopefully will work better than previous attempts, which put the `BdqQuit` handling in `Pdb.set_trace` - fixes: - jupyterlab/jupyterlab#12501 - refs: - ipython#876 - ipython#1273 - ipython#4474 - ipython#5306 - ipython#9731 - ipython#9942 - ipython#9950 - ipython#10006 - ipython#12378
64984e8
to
fc23598
Compare
# vscode ide stuff | ||
*.code-workspace | ||
.history | ||
.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really all these should be in your gitignore global:
https://docs.github.com/en/get-started/getting-started-with-git/ignoring-files
@meeseeksdev backport to 7.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Backport PR #13668: fix uncaught `BdbQuit` exceptions on ipdb `exit`
fixes:
BdbQuit
exception jupyterlab/jupyterlab#12501refs:
BdbQuit
is now handled in the top-most scope ofInteractiveShell.run_code
. This ensures thatBdbQuit
is correctly handled but can still do its job of breaking out of all user code/loops/further breakpoint requests. Hopefully will work better than previous attempts, which put theBdqQuit
handling inPdb.set_trace
.In terms of ipdb integration with the jlab UI, it's a big improvement.
Before:
After:
Much less noisy
pinging @Carreau for a review